Refactor FlintJob with FlintStatement and StatementExecutionManager #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
223c619 to
d3b9440
Compare
Signed-off-by: Louis Chu <clingzhi@amazon.com>
d3b9440 to
8cab459
Compare
ykmr1224
reviewed
Sep 9, 2024
spark-sql-application/src/main/scala/org/apache/spark/sql/JobOperator.scala
Outdated
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/JobOperator.scala
Outdated
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/JobOperator.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <clingzhi@amazon.com>
e0de9a2 to
aea6dc9
Compare
seankao-az
approved these changes
Sep 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…635) * Refactor FlintJob with FlintStatement and StatementExecutionManager Signed-off-by: Louis Chu <clingzhi@amazon.com> * Resolve comments Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 7d8f2b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…635) * Refactor FlintJob with FlintStatement and StatementExecutionManager Signed-off-by: Louis Chu <clingzhi@amazon.com> * Resolve comments Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit 7d8f2b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 10, 2024
noCharger
pushed a commit
that referenced
this pull request
Sep 10, 2024
…635) (#637) * Refactor FlintJob with FlintStatement and StatementExecutionManager * Resolve comments --------- (cherry picked from commit 7d8f2b0) Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
queryIdfrom spark confspark.flint.job.queryIdFlintJobusing theFlintStatementdata model and theStatementExecutionManagerinterface, and provideSingleStatementExecutionManageras theStatementExecutionManagerimplementation. With this enhancement,FlintJobmay manage the query lifecycle using these extension points. FlintJob's default behavior remains unchanged.Future task
#633
Issues Resolved
#602
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.