-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstracting source relations for enhanced covering index rewriting #391
Merged
dai-chen
merged 9 commits into
opensearch-project:main
from
dai-chen:refactor-covering-index-query-rewriter
Jun 26, 2024
Merged
Abstracting source relations for enhanced covering index rewriting #391
dai-chen
merged 9 commits into
opensearch-project:main
from
dai-chen:refactor-covering-index-query-rewriter
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
requested review from
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
June 21, 2024 16:48
penghuo
reviewed
Jun 21, 2024
...-integration/src/main/scala/org/opensearch/flint/spark/source/FlintSparkSourceRelation.scala
Show resolved
Hide resolved
...tion/src/main/scala/org/opensearch/flint/spark/source/FlintSparkSourceRelationProvider.scala
Show resolved
Hide resolved
...k-integration/src/main/scala/org/opensearch/flint/spark/source/file/FileSourceRelation.scala
Show resolved
Hide resolved
Signed-off-by: Chen Dai <daichen@amazon.com>
penghuo
approved these changes
Jun 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new abstractions for the covering index query rewriter, facilitating support for different source table relation matching and rewriting. This enhancement paves the way for future support of Iceberg table relations.
PR Planned
Changes
Added new
FlintSparkSourceRelationProvider
andFlintSparkSourceRelation
abstraction. Please see Scala doc for its responsibility in details. Basically,FlintSparkSourceRelationProvider
: determine if a given logical relation can be supported by Flint optimizer.FlintSparkSourceRelation
: provide all information required by query rewriting for a specific source relation.Will refactor
ApplyFlintSparkSkippingIndex
andFlintSparkValidationHelper.isTableProviderSupported
based on these in future.Testing
Issues Resolved
#298
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.