Implement blue/green deployment support in REPL mode #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features: - Add mutual exclusivity in session-based emr-s jobs to ensure only one job runs at a time, enhancing system stability during blue/green deployments. This allows active job exclusion and seamless task pickup by new jobs. Details in #94. Fixes: - Resolve a bug where long-running queries failed to cancel post-index mapping verification, by introducing timely query cancellation checks within the REPL loop. - Address issue #138 with the proposed short-term fix, improving reliability. Tests: - Conducted manual testing to validate blue/green deployment support and query cancellation. - Extended unit tests to cover new features and bug fixes. Signed-off-by: Kaituo Li <kaituo@amazon.com>
Signed-off-by: Kaituo Li <kaituo@amazon.com>
penghuo
reviewed
Nov 8, 2023
spark-sql-application/src/test/scala/org/apache/spark/sql/FlintREPLTest.scala
Show resolved
Hide resolved
spark-sql-application/src/test/scala/org/apache/spark/sql/FlintREPLTest.scala
Show resolved
Hide resolved
spark-sql-application/src/test/scala/org/apache/spark/sql/FlintREPLTest.scala
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Nov 8, 2023
flint-spark-integration/src/main/scala/org/opensearch/flint/app/FlintInstance.scala
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Nov 9, 2023
There was a problem hiding this comment.
could we make following value configurable. i found with 2 executors, some query can not finish by 10mins, but just in case user want to override it.
private val INACTIVITY_LIMIT_MILLIS = 30 * 60 * 1000
private val QUERY_EXECUTION_TIMEOUT = Duration(10, MINUTES)
private val QUERY_WAIT_TIMEOUT_MILLIS = 10 * 60 * 1000
Signed-off-by: Kaituo Li <kaituo@amazon.com>
changed. |
penghuo
reviewed
Nov 11, 2023
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Show resolved
Hide resolved
| | } | ||
| | } | ||
| | ] | ||
| | } | ||
| |}""".stripMargin | ||
|
|
There was a problem hiding this comment.
- state should be
waiting. - what if plugin cancel statement, but queryLoop use scroll search, the statement in scroll context still waiting state.
There was a problem hiding this comment.
- Can you explain a bit? Are you asking where I search for waiting state
"term": {
"state": "waiting"
}
},
- Yeah, we need to change to not to use scroll search.
penghuo
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features:
Fixes:
Tests:
Issues Resolved
#138
#94
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.