Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Join and Lookup IT on OpenSearch Table #1025

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add Join and Lookup IT on OpenSearch Table #1025

merged 1 commit into from
Feb 5, 2025

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Jan 30, 2025 •
edited
Loading

Description

  1. Add Join and Lookup IT on OpenSearch Table.
  2. Add Join example in OpenSearch Table doc

Related Issues

n/a

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • New added source code should include a copyright header
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo
Add Join and Lookup IT on OpenSearch Table
6f3238c 
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo self-assigned this Jan 30, 2025
@penghuo penghuo mentioned this pull request Jan 30, 2025
Open
12 tasks
YANG-DB
YANG-DB requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@penghuo
PPL Lookup already has its standard tests & documentation

Why do we need this test for ?

@penghuo
Copy link
Collaborator Author

penghuo commented Jan 31, 2025

@penghuo PPL Lookup already has its standard tests & documentation

Why do we need this test for ?

This PR is for test and demo OpenSearch Table (Index) support Join / Lookup in SQL and PPL.

I plan to reuse the existing PPLxxxIT tests to validate OpenSearch tables (indexes) and the correlation between CVSTable and OpenSearch indexes in upcoming PRs.

@penghuo penghuo requested a review from YANG-DB February 5, 2025 00:40
@penghuo penghuo added opensearch table enhancement New feature or request labels Feb 5, 2025
@penghuo
Copy link
Collaborator Author

penghuo commented Feb 5, 2025

@YANG-DB could u give another look?

@penghuo penghuo enabled auto-merge (squash) February 5, 2025 16:46
@penghuo penghuo merged commit 785d02b into opensearch-project:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-chen dai-chen dai-chen approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

Assignees

@penghuo penghuo

Labels
enhancement New feature or request opensearch table
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penghuo @dai-chen @YANG-DB