-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added query for initialized extensions #300
Added query for initialized extensions #300
Conversation
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
b2f073e
to
eb90621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending merge of #5658 and passing tests)
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
Run spotless to fix the build errors:
|
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
8d061db
to
49f77dd
Compare
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
src/main/java/org/opensearch/sdk/handlers/ExtensionDependencyResponseHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #300 +/- ##
============================================
- Coverage 73.22% 69.66% -3.57%
Complexity 117 117
============================================
Files 25 26 +1
Lines 508 534 +26
Branches 15 15
============================================
Hits 372 372
- Misses 128 154 +26
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* query for initialized extensions Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * apply spotless Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * add javadoc Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> * address comment Signed-off-by: Frank Lou <mloufra@amazon.com> Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou mloufra@amazon.com
Description
Create a feature to have an extension query to OpenSearch to obtain a list of initialized extensions and determine whether a particular extension is initialized.
Equivalent PR on OpenSearch :
opensearch-project/OpenSearch#5628opensearch-project/OpenSearch#5658Issues Resolved
fixes #149
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.