Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added query for initialized extensions #300

Merged

Conversation

mloufra
Copy link
Contributor

@mloufra mloufra commented Dec 28, 2022

Signed-off-by: Frank Lou mloufra@amazon.com

Description

Create a feature to have an extension query to OpenSearch to obtain a list of initialized extensions and determine whether a particular extension is initialized.
Equivalent PR on OpenSearch : opensearch-project/OpenSearch#5628 opensearch-project/OpenSearch#5658

Issues Resolved

fixes #149

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mloufra mloufra force-pushed the query-for-initialized-extensions branch from b2f073e to eb90621 Compare December 28, 2022 19:40
dbwiddis
dbwiddis previously approved these changes Dec 30, 2022
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending merge of #5658 and passing tests)

dbwiddis
dbwiddis previously approved these changes Dec 30, 2022
@dbwiddis dbwiddis requested a review from ryanbogan December 30, 2022 21:40
@mloufra mloufra requested a review from dbwiddis December 30, 2022 23:40
@owaiskazi19
Copy link
Member

Run spotless to fix the build errors:

> Task :spotlessJava
FAILURE: Build failed with an exception.
> Task :spotlessJavaCheck FAILED

Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
@mloufra mloufra force-pushed the query-for-initialized-extensions branch from 8d061db to 49f77dd Compare January 5, 2023 23:08
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
Signed-off-by: Frank Lou <mloufra@amazon.com>
@mloufra mloufra requested a review from dbwiddis January 9, 2023 18:03
Signed-off-by: Frank Lou <mloufra@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #300 (fff3446) into main (4555529) will decrease coverage by 3.56%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #300      +/-   ##
============================================
- Coverage     73.22%   69.66%   -3.57%     
  Complexity      117      117              
============================================
  Files            25       26       +1     
  Lines           508      534      +26     
  Branches         15       15              
============================================
  Hits            372      372              
- Misses          128      154      +26     
  Partials          8        8              
Impacted Files Coverage Δ
...main/java/org/opensearch/sdk/ExtensionsRunner.java 65.77% <0.00%> (-4.74%) ⬇️
...k/handlers/ExtensionDependencyResponseHandler.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mloufra mloufra merged commit c7c2d87 into opensearch-project:main Jan 10, 2023
@mloufra mloufra deleted the query-for-initialized-extensions branch January 10, 2023 17:15
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
* query for initialized extensions

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* apply spotless

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* add javadoc

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

* address comment

Signed-off-by: Frank Lou <mloufra@amazon.com>

Signed-off-by: Frank Lou <mloufra@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Let an extension query OpenSearch for all initialized extensions
5 participants