-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] "Misspelling" on setting MaxAnalyzedOffset on IHighlight #321
Labels
bug
Something isn't working
Comments
gjunge
pushed a commit
to gjunge/opensearch-net
that referenced
this issue
Aug 17, 2023
… name to match with the one introduced in OpenSearch 2.2.0 Signed-off-by: Gideon Junge <gjunge@gmail.com>
gjunge
added a commit
to gjunge/opensearch-net
that referenced
this issue
Aug 17, 2023
… name to match with the one introduced in OpenSearch 2.2.0 Signed-off-by: Gideon Junge<gjunge@gmail.com>
gjunge
added a commit
to gjunge/opensearch-net
that referenced
this issue
Aug 17, 2023
… name to match OS 2.2.0 Signed-off-by: Gideon Junge <gjunge@gmail.com>
gjunge
added a commit
to gjunge/opensearch-net
that referenced
this issue
Aug 19, 2023
… name to match OS 2.2.0 Signed-off-by: Gideon Junge <gjunge@gmail.com>
Xtansia
pushed a commit
to Xtansia/opensearch-net
that referenced
this issue
Aug 20, 2023
… name to match OS 2.2.0 (opensearch-project#322) * Fixes opensearch-project#321: fix highlight max_analyzer_offset field name to match OS 2.2.0 Signed-off-by: Gideon Junge <gjunge@gmail.com> * extend existing highlighting unit test Signed-off-by: Gideon Junge <gjunge@gmail.com> * Create > 2.2.0 unit test Signed-off-by: Gideon Junge <gjunge@gmail.com> * Implement HighlightField level max_analyzer_offset max_analyzer_offset can be set both on highlight in general, and on specific fields. Signed-off-by: Gideon Junge <gjunge@gmail.com> --------- Signed-off-by: Gideon Junge <gjunge@gmail.com> (cherry picked from commit 8ad8057)
Xtansia
pushed a commit
to Xtansia/opensearch-net
that referenced
this issue
Aug 20, 2023
… name to match OS 2.2.0 (opensearch-project#322) * Fixes opensearch-project#321: fix highlight max_analyzer_offset field name to match OS 2.2.0 Signed-off-by: Gideon Junge <gjunge@gmail.com> * extend existing highlighting unit test Signed-off-by: Gideon Junge <gjunge@gmail.com> * Create > 2.2.0 unit test Signed-off-by: Gideon Junge <gjunge@gmail.com> * Implement HighlightField level max_analyzer_offset max_analyzer_offset can be set both on highlight in general, and on specific fields. Signed-off-by: Gideon Junge <gjunge@gmail.com> --------- Signed-off-by: Gideon Junge <gjunge@gmail.com> (cherry picked from commit 8ad8057)
Xtansia
added a commit
that referenced
this issue
Aug 22, 2023
…2.2.0 (#322) (#324) * Fixes #321: fix highlight max_analyzer_offset field name to match OS 2.2.0 Signed-off-by: Gideon Junge <gjunge@gmail.com> * extend existing highlighting unit test Signed-off-by: Gideon Junge <gjunge@gmail.com> * Create > 2.2.0 unit test Signed-off-by: Gideon Junge <gjunge@gmail.com> * Implement HighlightField level max_analyzer_offset max_analyzer_offset can be set both on highlight in general, and on specific fields. Signed-off-by: Gideon Junge <gjunge@gmail.com> --------- Signed-off-by: Gideon Junge <gjunge@gmail.com> (cherry picked from commit 8ad8057) Co-authored-by: Gideon Junge <gjunge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the bug?
Same bug as opensearch-project/opensearch-java#553 , since this part was copied from the ES clients. ES implemented this field as
max_analyzed_offset
(see ES docs), while OpenSearch implemented the field asmax_analyzer_offset
in 2.2.0 (see OS docs)As can be seen in the Java client bug description, using this field will lead to this error
How can one reproduce the bug?
What is the expected behavior?
Update the api to match the OpenSearch Highlight setting max_analyzer_offset
What is your host/environment?
AWS Managed OpenSearch service 2.7.
The text was updated successfully, but these errors were encountered: