Transformer configuration UX changes #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added all of the transformer jars to the runtime closure of the replayer since it's going to be a challenge for users using a cloud-deployment shrink-wrap solution to add addition jarfiles. Change the syntax/rules for Transformer configs. * If no argument was specified for the transformer config, no transformer used, regardless of what's in the classpath. * To use multiple transformers, you’ll need to specify the transformer-config as a json array (of json transformer configs) * To use one transformer with default settings, you can JUST put the name of the transformer in the arg. e.g. --transformer-config JsonTransformerForOpenSearch23PlusTargetTransformerProvider. I've also updated the key name to only use the short, simple name of a class rather than the fully qualified one with the namespace. Add a NoopTransformer, which makes unit and sanity testing a lot simpler. Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
# Conflicts: # TrafficCapture/trafficReplayer/build.gradle
(repeated) I've added all of the transformer jars to the runtime closure of the replayer since it's going to be a challenge for users using a cloud-deployment shrink-wrap solution to add addition jarfiles. Change the syntax/rules for Transformer configs. * If no argument was specified for the transformer config, no transformer used, regardless of what's in the classpath. * To use multiple transformers, you’ll need to specify the transformer-config as a json array (of json transformer configs) * To use one transformer with default settings, you can JUST put the name of the transformer in the arg. e.g. --transformer-config JsonTransformerForOpenSearch23PlusTargetTransformerProvider. I've also updated the key name to only use the short, simple name of a class rather than the fully qualified one with the namespace. Add a NoopTransformer, which makes unit and sanity testing a lot simpler. Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
13eb329 to
f0dcc00
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
============================================
+ Coverage 62.67% 62.86% +0.19%
- Complexity 869 871 +2
============================================
Files 100 100
Lines 4343 4341 -2
Branches 412 410 -2
============================================
+ Hits 2722 2729 +7
+ Misses 1348 1341 -7
+ Partials 273 271 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lewijacn
approved these changes
Nov 14, 2023
| @Test | ||
| public void testThatSimpleNoopTransformerLoads() throws Exception { | ||
| var noopTransformer = new TransformationLoader() | ||
| .getTransformerFactoryLoader("localhost", "NoopTransformerProvider"); |
There was a problem hiding this comment.
Do we currently have any other existing transformation providers besides "NoopTransformerProvider" ?
There was a problem hiding this comment.
In the base package, no. In TrafficReplayer, there's a HostTransformer & soon a UserAgentTransformer. Transformers exist for Jolt and JMESPath in separate packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transformation improvements.
I've added all of the transformer jars to the runtime closure of the replayer since it's going to be a challenge for users using a cloud-deployment shrink-wrap solution to add addition jarfiles.
Change the syntax/rules for Transformer configs.
I've also updated the key name to only use the short, simple name of a class rather than the fully qualified one with the namespace.
Add a NoopTransformer, which makes unit and sanity testing a lot simpler.
Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1429
Testing
gradle build
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.