Added initial CloudWatch Dashboard for RFS #1147
Conversation
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
=========================================
Coverage 80.78% 80.78%
Complexity 2947 2947
=========================================
Files 399 399
Lines 15089 15089
Branches 1017 1017
=========================================
Hits 12190 12190
Misses 2288 2288
Partials 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| break; | ||
| } | ||
| } | ||
| console.log(`returning ${JSON.stringify(variables)}`); |
There was a problem hiding this comment.
probably don't need this anymore
| "inputType": "input", | ||
| "id": "ACCOUNT_ID", | ||
| "label": "ACCOUNT_ID", | ||
| "defaultValue": "ACCOUNT_ID", |
There was a problem hiding this comment.
minor, doesn't follow the pattern of the other placeholder values
| } | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
nit: can we run a JSON formatter here? it looks like it's a bit off
| for (const variable of variables) { | ||
| if (variable.id === variableName) { | ||
| variable.defaultValue = defaultValue; | ||
| console.log(`changing ${variable.defaultValue} to ${defaultValue}`); |
There was a problem hiding this comment.
delete this line too?
Signed-off-by: Chris Helma <chelma+github@amazon.com>
| "property": "DomainName", | ||
| "inputType": "input", | ||
| "id": "TC_DOMAIN_NAME", | ||
| "label": "Target Cluster Domain Name", |
There was a problem hiding this comment.
Thoughts on adding a search here for dropdown instead of input?
"search": "{AWS/ES,ClientId,DomainName} MetricName=CPUUtilization",
"populateFrom": "DomainName"
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Signed-off-by: Chris Helma <chelma+github@amazon.com>
| "view": "timeSeries", | ||
| "stacked": false, | ||
| "metrics": [ | ||
| [ { "expression": "METRICS()/1000", "id": "e1", "region": "REGION" } ], |
There was a problem hiding this comment.
Should we need to do the same / PERIOD(m1)*60 here
| "stacked": false, | ||
| "metrics": [ | ||
| [ { "expression": "METRICS()/1000", "id": "e1", "region": "REGION" } ], | ||
| [ "AWS/ES", "IndexingRate", "DomainName", "TC_DOMAIN_NAME", "ClientId", "ACCOUNT_ID", { "region": "region", "label": "Document Ingested per 60 seconds - MIN: ${MIN}, MAX: ${MAX}, AVG: ${AVG}", "id": "m1", "visible": false } ] |
There was a problem hiding this comment.
Let's add a (including replicas) here on the label
| "period": 60, | ||
| "region": "REGION", | ||
| "stacked": false, | ||
| "title": "RFS Workers Reporting in During Period", |
There was a problem hiding this comment.
nit: should we remove During Period from the title here?
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Description
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.