Document how to use Java 8 Time (JSR 310) objects #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
previously approved these changes
Oct 31, 2022
dblock
requested changes
Nov 1, 2022
There was a problem hiding this comment.
Let's document this in https://github.com/opensearch-project/opensearch-java/blob/main/USER_GUIDE.md, please.
I'm not clear what/where should be documented. This is mostly an internal implementation detail that should be transparent to users. Are you suggesting adding another field to the sample data? I could add a JSR310 class like Duration, but the USER_GUIDE example barely even touches the full range of Java classes, sticking to String examples. |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dblock
previously approved these changes
Nov 9, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
VachaShah
approved these changes
Nov 11, 2022
reta
approved these changes
Nov 11, 2022
|
@dblock LGTM? |
owaiskazi19
approved these changes
Nov 11, 2022
dblock
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Widdis widdis@gmail.com
Description
Updates docs to show how to serialize/deserialize classes from JSR-310 (Java 8) Date and Time API
Issues Resolved
Fixes #250
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.