Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jackson-databind for CVE-2020-36518 #129

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Updating jackson-databind to 2.12.6.1 for CVE-2020-36518.

Issues Resolved

#121

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah requested review from a team and madhusudhankonda as code owners March 28, 2022 22:21
dblock
dblock previously approved these changes Mar 29, 2022
reta
reta previously approved these changes Mar 30, 2022
@@ -149,7 +149,7 @@ dependencies {
// Apache 2.0

implementation("com.fasterxml.jackson.core", "jackson-core", jacksonVersion)
implementation("com.fasterxml.jackson.core", "jackson-databind", jacksonVersion)
implementation("com.fasterxml.jackson.core", "jackson-databind", "2.12.6.1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to introduce jacksonDatabindVersion so we could change jacksonVersion & jacksonDatabindVersion in lockstep if needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me. @VachaShah , WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good! Added a commit to include jacksonDatabindVersion.

CEHENKLE
CEHENKLE previously approved these changes Mar 30, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah dismissed stale reviews from CEHENKLE, reta, and dblock via 775f4fa March 30, 2022 18:12
@VachaShah VachaShah requested review from CEHENKLE and dblock March 30, 2022 18:15
@VachaShah
Copy link
Collaborator Author

@reta I am not able to re-request a review from you

@dblock dblock requested a review from saratvemulapalli March 30, 2022 20:37
Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Food for thought, is there a way we can fetch the dependency version defined in OpenSearch and consume it here?

@VachaShah
Copy link
Collaborator Author

Food for thought, is there a way we can fetch the dependency version defined in OpenSearch and consume it here?

I can look to see how that can work.

@VachaShah VachaShah merged commit c342838 into opensearch-project:main Mar 30, 2022
@VachaShah VachaShah deleted the jackson-databind-update branch March 30, 2022 20:51
@reta
Copy link
Collaborator

reta commented Mar 30, 2022

Food for thought, is there a way we can fetch the dependency version defined in OpenSearch and consume it here?

I can look to see how that can work.

@VachaShah sorry if that is what you already have in mind, but Gradle has this version catalog feature with I think we could leverage to align the dependencies between all OpenSearch ecosystem.

[1] https://docs.gradle.org/current/userguide/platforms.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants