-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: model upload failed with model group level access control #677
Merged
kavilla
merged 1 commit into
opensearch-project:main
from
wanglam:fix/ml-commons-no-model-group-id
May 26, 2023
Merged
fix: model upload failed with model group level access control #677
kavilla
merged 1 commit into
opensearch-project:main
from
wanglam:fix/ml-commons-no-model-group-id
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
42 tasks
I will fix the test failure which is most likely due to startup, not tar, not test cases. |
Hi @wanglam seems like there are still some errors even in local test: sec enabled log
|
overview_spec.js.mp4 |
Offline discussion with @wanglam that latest ML Commons Dash plugin must be installed on 2.8.0 in order to test this. Thanks. |
peterzhuamazon
approved these changes
May 26, 2023
kavilla
approved these changes
May 26, 2023
kavilla
approved these changes
May 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit b159ff0)
peterzhuamazon
pushed a commit
that referenced
this pull request
May 26, 2023
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 15, 2023
…earch-project#677) (opensearch-project#684) Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit b159ff0) Co-authored-by: Lin Wang <wonglam@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ml-commons 2.8 will bring model group level access control feature. The new feature will break old model upload process. This PR enable model register upload by URL and create model group before model upload. Then model can be uploaded and deployed.
This PR should be backport to
2.x
branch and already passed in the local environment.Test video: https://github.com/opensearch-project/opensearch-dashboards-functional-test/assets/4034161/6044acbe-9be6-48fb-94df-2d3551cd506c
Test screenshot:![image](https://private-user-images.githubusercontent.com/4034161/240928428-397d2309-8159-4ed0-a7a6-4d248617a34f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2Mjg2NDQsIm5iZiI6MTczOTYyODM0NCwicGF0aCI6Ii80MDM0MTYxLzI0MDkyODQyOC0zOTdkMjMwOS04MTU5LTRlZDAtYTdhNi00ZDI0ODYxN2EzNGYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTQwNTQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjdhN2ZjNjYzOThjNzllY2UxZWJmZmVkZjI5MjhjZWI3MjI1OTc2NWM1ODQ2OWUzODNkYjc2Nzg0MDAwZGZmNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.bsH2Ri88WGI_KU6WHaZS_0AGcq4f-7t85DhiuHET8EA)
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.