-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ML Commons smoke tests #5369
Add ML Commons smoke tests #5369
Conversation
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5369 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 202 202
Lines 7043 7043
=======================================
Hits 6483 6483
Misses 560 560 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rithin-pullela-aws, please help fix yamllint here.
You can try with pipenv run yamllint src/test_workflow/smoke_test/smoke_tests_spec/2.x/ml-commons.yml
to test it locally.
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@zelinh Do we need to run this in local before merging? |
I did a dry run locally and these look good to me.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the onboarding here. @rithin-pullela-aws
LGTM.
Description
This adds smoke tests for ML Commons.
Issues Resolved
opensearch-project/ml-commons#3541
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.