Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML Commons smoke tests #5369

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

rithin-pullela-aws
Copy link
Contributor

Description

This adds smoke tests for ML Commons.

Issues Resolved

opensearch-project/ml-commons#3541

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (e2c2fee) to head (d9f4165).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5369   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         202      202           
  Lines        7043     7043           
=======================================
  Hits         6483     6483           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rithin-pullela-aws, please help fix yamllint here.
You can try with pipenv run yamllint src/test_workflow/smoke_test/smoke_tests_spec/2.x/ml-commons.yml to test it locally.

Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
@gaiksaya
Copy link
Member

@zelinh Do we need to run this in local before merging?

@zelinh
Copy link
Member

zelinh commented Mar 10, 2025

@zelinh Do we need to run this in local before merging?

I did a dry run locally and these look good to me.

2025-03-10 13:00:37 INFO     | ml-commons           | /_bulk?refresh=true POST | PASS  |
2025-03-10 13:00:37 INFO     | ml-commons           | /_cluster/settings PUT | PASS  |
2025-03-10 13:00:37 INFO     | ml-commons           | /_plugins/_ml/_train/kmeans POST | PASS  |
2025-03-10 13:00:37 INFO     | ml-commons           | /_plugins/_ml/models/_register POST | PASS  |
2025-03-10 13:00:37 INFO     | ml-commons           | /_plugins/_ml/stats GET | PASS  |
2025-03-10 13:00:37 INFO     | ml-commons           | /_plugins/_ml/stats/ml_request_count GET | PASS  |
2025-03-10 13:00:37 INFO     | ml-commons           | /iris_data_train_predict_it PUT | PASS  |

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the onboarding here. @rithin-pullela-aws
LGTM.

@gaiksaya gaiksaya merged commit d5d0c19 into opensearch-project:main Mar 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants