Add notifications to 1.0 maven release. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it notification or notification(s)? It is very inconsistent across this PR. |
dblock
reviewed
Aug 25, 2021
manifests/opensearch-1.0.0-maven.yml
Outdated
| - name: common-utils | ||
| repository: https://github.com/opensearch-project/common-utils.git | ||
| ref: 1.0 | ||
| ref: d05a50e220a239f09a9048a368bc1b698cb7e6bd |
There was a problem hiding this comment.
Should we create a tag and use that at the SHA?
There was a problem hiding this comment.
Yes that would be great, the existing 1.0.0.0 tag is not building the correct artifact. I personally do not have the access to create a tag in that repo afaik
manifests/opensearch-1.0.0-maven.yml
Outdated
| - name: common-utils | ||
| repository: https://github.com/opensearch-project/common-utils.git | ||
| ref: 1.0 | ||
| ref: d05a50e220a239f09a9048a368bc1b698cb7e6bd |
There was a problem hiding this comment.
What is this specific commit id? Why cant we use an existing tag?
There was a problem hiding this comment.
The 1.0.0.0 tag is building an -rc artifact, not a release artifact
dblock
approved these changes
Aug 25, 2021
Signed-off-by: Marc Handalian <handalm@amazon.com>
peternied
approved these changes
Aug 25, 2021
alborotogarcia
pushed a commit
to alborotogarcia/opensearch-build
that referenced
this pull request
Sep 7, 2021
Signed-off-by: Marc Handalian <handalm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Handalian handalm@amazon.com
Description
Adding notifications to 1.0 maven release.
Updated to build tags and a specific sha of common-utils.
Issues Resolved
Follow up on #307
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.