Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Input Manifest for 1.0 maven release. #307

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Add Input Manifest for 1.0 maven release. #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bundle-workflow/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ This workflow builds a complete OpenSearch bundle from source. You can currently

### Build from Source

Each build requires a manifest to be passed as input. We currently have the following input manifests:

| name | description |
|-------------|-------------------------------------------------------------------------------------|
| [opensearch-1.0.0.yml](/manifests/opensearch-1.0.0.yml) | Manifest to reproduce 1.0.0 build. |
| [opensearch-1.0.0-maven.yml](/manifests/opensearch-1.0.0-maven.yml)| One-time manifest to build and push maven artifacts for 1.0 from tags. Going forward a separate maven manifest is not required. For 1.0.0 we do not have solid 1.0 refs for all repos nor do we need to rebuild the full bundle.|
| [opensearch-1.1.0.yml](/manifests/opensearch-1.1.0.yml)| Manifest to build upcoming 1.x release.


Usage:
```bash
./bundle-workflow/build.sh manifests/opensearch-1.1.0.yml --snapshot
```
Expand Down
15 changes: 15 additions & 0 deletions manifests/opensearch-1.0.0-maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
schema-version: 1.0
build:
name: OpenSearch
version: 1.0.0
components:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is alerting notification also required by any plugin as dependency? We used to publish that too. Just confirming

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock we would also want alerting/notification, if we are publishing these to maven. Consumed by Index Management 1.0.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I don't see any artifacts copied in their build script, but they are pushed to maven local.

https://github.com/opensearch-project/opensearch-build/blob/main/bundle-workflow/scripts/components/alerting/build.sh#L71

Lets take this as a follow up, I don't want to hold the others while this gets sorted out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is following up on this? ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on this right now

- name: OpenSearch
repository: https://github.com/opensearch-project/OpenSearch.git
ref: 1.0
- name: common-utils
repository: https://github.com/opensearch-project/common-utils.git
ref: 1.0
- name: job-scheduler
repository: https://github.com/opensearch-project/job-scheduler.git
ref: 1.0.0.0