Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build][Test] OS and OSD improvements plus support for Playground #1785

Merged
merged 7 commits into from
Mar 21, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 19, 2022

Description

Original PR: #1756

While using a child folder 'Playground' in Jenkins I had to do a number of
changes to support a successful test run. I also included the ability to
skip publishing the notification not to spam channels from builds from
for example Playground. Also ability to skip building docker because
from what I could tell it was publishing docker images from Playground
pipelines as well.

If the user attempts to pass an empty string it will skip the integ tests.

Finally, some cleanup to integ tests to use the input manifest to container image.
Also, make integ tests run in docker container for OpenSearch. Use libtester for
detectTestDockerAgent

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

#1688
#1687
#1686
#1758

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kavilla added 4 commits March 19, 2022 02:31
While using a child folder 'Playground' in Jenkins I had to do a number of
changes to support a successful test run. I also included the ability to
skip publishing the notification not to spam channels from builds from
for example `Playground`. Also ability to skip building docker because
from what I could tell it was publishing docker images from `Playground`
pipelines as well.

Finally, some cleanup to integ tests to use the input manifest to container image.
Also, make integ tests run in docker container for OpenSearch.

Issues resolved:
opensearch-project#1688
opensearch-project#1687
opensearch-project#1686

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Issue Resolved:
opensearch-project#1758

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla requested a review from a team as a code owner March 19, 2022 02:33
@kavilla kavilla requested a review from zelinh March 19, 2022 02:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #1785 (11cd736) into main (9cf9039) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1785   +/-   ##
=========================================
  Coverage     94.48%   94.48%           
  Complexity       18       18           
=========================================
  Files           172      173    +1     
  Lines          3610     3611    +1     
  Branches         27       27           
=========================================
+ Hits           3411     3412    +1     
  Misses          195      195           
  Partials          4        4           
Impacted Files Coverage Δ
...sts/jenkins/jobs/DetectTestDockerAgent_Jenkinsfile 100.00% <ø> (ø)
.../jenkins/jobs/CreateTestResultsMessage_Jenkinsfile 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf9039...11cd736. Read the comment docs.

kavilla added 3 commits March 19, 2022 02:40
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla enabled auto-merge (squash) March 19, 2022 03:17
@kavilla kavilla merged commit 79ecfb9 into opensearch-project:main Mar 21, 2022
kavilla added a commit to kavilla/opensearch-build that referenced this pull request Mar 21, 2022
Incorrectly added the colon to beforeAgent in the docker build step
for OpenSearch.

Error added in this PR:
opensearch-project#1785

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 21, 2022
Incorrectly added the colon to beforeAgent in the docker build step
for OpenSearch.

Error added in this PR:
#1785

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants