-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build][Test] OS and OSD improvements plus support for Playground #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using a child folder 'Playground' in Jenkins I had to do a number of changes to support a successful test run. I also included the ability to skip publishing the notification not to spam channels from builds from for example `Playground`. Also ability to skip building docker because from what I could tell it was publishing docker images from `Playground` pipelines as well. Finally, some cleanup to integ tests to use the input manifest to container image. Also, make integ tests run in docker container for OpenSearch. Issues resolved: opensearch-project#1688 opensearch-project#1687 opensearch-project#1686 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Issue Resolved: opensearch-project#1758 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1785 +/- ##
=========================================
Coverage 94.48% 94.48%
Complexity 18 18
=========================================
Files 172 173 +1
Lines 3610 3611 +1
Branches 27 27
=========================================
+ Hits 3411 3412 +1
Misses 195 195
Partials 4 4
Continue to review full report at Codecov.
|
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
dblock
approved these changes
Mar 21, 2022
kavilla
added a commit
to kavilla/opensearch-build
that referenced
this pull request
Mar 21, 2022
Incorrectly added the colon to beforeAgent in the docker build step for OpenSearch. Error added in this PR: opensearch-project#1785 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
1 task
kavilla
added a commit
that referenced
this pull request
Mar 21, 2022
Incorrectly added the colon to beforeAgent in the docker build step for OpenSearch. Error added in this PR: #1785 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original PR: #1756
While using a child folder 'Playground' in Jenkins I had to do a number of
changes to support a successful test run. I also included the ability to
skip publishing the notification not to spam channels from builds from
for example
Playground
. Also ability to skip building docker becausefrom what I could tell it was publishing docker images from
Playground
pipelines as well.
If the user attempts to pass an empty string it will skip the integ tests.
Finally, some cleanup to integ tests to use the input manifest to container image.
Also, make integ tests run in docker container for OpenSearch. Use libtester for
detectTestDockerAgent
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#1688
#1687
#1686
#1758
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.