Disable propagate argument when triggering child job #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1628 +/- ##
============================================
- Coverage 94.67% 94.53% -0.15%
Complexity 13 13
============================================
Files 163 163
Lines 3435 3437 +2
Branches 21 21
============================================
- Hits 3252 3249 -3
- Misses 180 185 +5
Partials 3 3
Continue to review full report at Codecov.
|
|
Instead add |
Great suggestion! That works from my testing. Working on the change. Thanks! |
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
peternied
approved these changes
Feb 15, 2022
gaiksaya
approved these changes
Feb 16, 2022
1 task
zelinh
added a commit
to zelinh/opensearch-build
that referenced
this pull request
Feb 16, 2022
…rch-project#1628)" This reverts commit e0a34eb. Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
added a commit
that referenced
this pull request
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zelin Hao zelinhao@amazon.com
Description
Currently our check-for-build jenkins job will fail if its child job fails, which also sends out failure notification. Disabled propagate argument will not propagate the results of child job and continue the workflow on the current job. This job only fails if there is an issue in check-for-build itself.
Issues Resolved
#1627
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.