-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload index.json from artifacts upload #1622
upload index.json from artifacts upload #1622
Conversation
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Want to call out one build during my testing. This build (build 13) failed but the I will check more to see if this is a concern. |
The failure was from the snapshot build, not from the x64/arm64. A 'transient' failure would be because of a network hiccup, the as the builds output files are expected to be fully deterministic, and the error was a file was not found. Is it possible there was another change on your branch that altered the behavior.
I would recommend working with @abhinavGupta16 on a test for the opensearch distribution build to make sure the behavior you've added isn't impacting snapshot builds unexpectedly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a Groovy test for getIndexFileRoot
, otherwise LGTM.
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1622 +/- ##
=========================================
Coverage 94.67% 94.67%
- Complexity 13 14 +1
=========================================
Files 163 163
Lines 3437 3438 +1
Branches 21 21
=========================================
+ Hits 3254 3255 +1
Misses 180 180
Partials 3 3
Continue to review full report at Codecov.
|
The build is using the branch of this PR and thus the touched code is all in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Link to main issue #1492 |
Description
As #1569 grows, extract the logic to upload
index.json
to current PR.Issues Resolved
See related PR above.
Test
The build link
http://jenki-jenki-fpgmrv2ryxko-1366042710.us-east-1.elb.amazonaws.com/job/Playground/job/tianleh-distribution-url-latest/14/
Verified that the latest build number is correct.

https://ci.opensearch.org/ci/dbc/Playground/tianleh-distribution-url-latest/2.0.0/index.json
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.