Changes to support ramp-up feature #725
Conversation
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Thank you. Yes, I'm working on a doc that explains how to use this feature. |
| return f"TaskAllocation [{self.client_index_in_task}/{self.task.clients}] for {self.task} " \ | ||
| f"and [{self.global_client_index}/{self.total_clients}] in total" |
There was a problem hiding this comment.
Hoping to understand this better: Each tests has a total number of clients and each task is allocated group of those clients. So self.client_index_in_task tracks which client in the allocated group is performing the task while self.global_client_index tracks which client out of all clients is currently performing this task?
There was a problem hiding this comment.
That's pretty much how I understood it. So now TaskAllocation knows both the clients position within a task (self.client_index_in_task) as well as the clients position in the overall benchmark (self.global_client_index). Maybe @rishabh6788 can correct me if I'm wrong
There was a problem hiding this comment.
yes. Consider a case there we have 3 parallel tasks a, b and c, where we have declared total 3 clients at parallel task level and then have 1 client each for task a and b and then 2 clients for task c.
In the task allocation matrix the 3 clients declared at parallel block level will represent global client indices and clients declared at each task level will be used as client index at each task level. It does get a bit confusing, let me know if you have any questions.
776b750 to
372439f
Compare
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Description
As mentioned in #713 this PR introduces a new task property, ramp-up-time-period. When provided, opensearch-benchmark will gradually scale up clients based on the time-period and number of clients provided.
Issues Resolved
#713
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.