-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request start and end parameter to sleep runner #491
Conversation
Worker coordinator expects every runner to have request start and request end key. Added client request start and client request end before and after sleep. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If there are any other issues that require similar changes, we should create an issue to keep track of them and close them out.
Good day I can open an Issue if this is not the right place to report a regression. With a simple setup of OSB 1.6.0 and this added to my existing test_procedures->schedule: {
"operation": {"operation-type": "sleep", "duration": 1.5}
} I am getting (after my other operations and after the
Changing the Sleep Runner code to do the async def __call__(self, opensearch, params):
sleep_duration = mandatory(params, "duration", "sleep")
try:
request_context_holder.on_client_request_start()
opensearch.on_request_start()
await asyncio.sleep(sleep_duration)
finally:
opensearch.on_request_end()
request_context_holder.on_client_request_end() |
Description
Worker coordinator expects every runner to have request start and request end key.
Added client request start and client request end before and after sleep.
Issues Resolved
#485
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.