Make neighbor's dataset path as optional #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
approved these changes
Feb 19, 2024
IanHoang
reviewed
Feb 20, 2024
IanHoang
reviewed
Feb 20, 2024
| @@ -2862,20 +2862,20 @@ def test_params_default(self): | |||
| Context.QUERY, | |||
| self.data_set_dir | |||
| ) | |||
| neighbors_data_set_path = create_data_set( | |||
| create_data_set( | |||
There was a problem hiding this comment.
When is this being used? Should we just remove this callable?
There was a problem hiding this comment.
Good point, In this case we are creating neighbor's dataset as part of query's dataset. In first step, you see that query dataset is created and it returns the dataset path. In step two, we pass same file and in this case, we don't create new file, instead create new dataset with key as neighbors in same file.
If neighbor's dataset path or corpus is not set, use dataset path as neighbor's dataset path. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
IanHoang
approved these changes
Feb 20, 2024
gkamat
reviewed
Feb 22, 2024
Comment on lines
-1076
to
-1079
| if not self.data_set_path and not self.data_set_corpus: | ||
| raise exceptions.ConfigurationError( | ||
| "Dataset is missing. Provide either dataset file path or valid corpus.") | ||
| if self.data_set_path and self.data_set_corpus: |
There was a problem hiding this comment.
What happens when both path and corpus are specified?
| raise exceptions.ConfigurationError( | ||
| "Provide either dataset file path '%s' or corpus '%s'." % (self.data_set_path, self.data_set_corpus)) | ||
| "Provide either neighbor's dataset file path '%s' or corpus '%s'." % (file_path, corpus)) |
There was a problem hiding this comment.
Recommend using f-strings for newer code.
| @@ -188,12 +188,16 @@ def create_data_set( | |||
| dimension: int, | |||
| extension: str, | |||
| data_set_context: Context, | |||
| data_set_dir | |||
| data_set_dir, | |||
There was a problem hiding this comment.
Please add a type hint for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If neighbor's dataset path or corpus is not set,
use dataset path as neighbor's dataset path. This will avoid
users to set neighbors dataset path if same h5 file with
different dataset is used.
Issues Resolved
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.