Add support for a data corpora source-url field to specify a corpus file directly #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanHoang
reviewed
Feb 12, 2024
tests/workload/loader_test.py
Outdated
Comment on lines
320
to
321
| base_url="http://benchmarks.elasticsearch.org/corpora", | ||
| source_url="http://benchmarks.elasticsearch.org/corpora/unit-test/docs.json.bz2", |
There was a problem hiding this comment.
Nit: Although this is for a unittest, is there another link we could use to test it out with instead of one from elastic?
There was a problem hiding this comment.
That's a good point. These were cloned from other tests that have that link. Will go through all and replace them in a separate commit.
IanHoang
approved these changes
Feb 12, 2024
…irectly. Signed-off-by: Govind Kamat <govkamat@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Files in data corpora may have paths that don't conform to the "corpus URL / filename" convention, for instance with object stores. This change adds support for a
source-urlfield that takes precedence over the corpus URL if it is specified. Existing workloads will continue to work as is.Testing
Ran unit tests and integ tests, and a couple of workloads in test mode.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.