Improve the telemetry device "Segment Replication Stats" by changing to parse JSON format and using numeric bytes value #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tespace problem for telemetry - segment replication stats Signed-off-by: Tianli Feng <ftianli@amazon.com>
… API response Signed-off-by: Tianli Feng <ftianli@amazon.com>
849ec67 to
10a1fea
Compare
dreamer-89
reviewed
Aug 10, 2023
| "shard_id": "[so][0]", | ||
| "target_node": "node-1", | ||
| "target_host": "127.0.0.1", | ||
| "shard_id": "[logs-211998][6]", |
There was a problem hiding this comment.
nit: Is shard_id, target_node change needed in tests ?
There was a problem hiding this comment.
@dreamer-89 Thanks a lot for your review! 👏 The change is indeed not necessary, I just updated the test with a real API response from my recent performance test. I think it's fine to keep the changes.
dreamer-89
approved these changes
Aug 10, 2023
Signed-off-by: Tianli Feng <ftianli@amazon.com>
|
Manually tested again after the last commit |
|
@IanHoang Thank you for your review! It's embarrassed that I introduced the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although PR #339 added new telemetry device "Segment Replication Stats", there are some problems. The PR will solve the problem.
str.split(" ")as the delimiter to parse the REST API response, where maybe more than 1 space between adjacent values.For detail, see #339 (comment).
Issues Resolved
Address a problem related to issue #339
The screenshot illustrates the current problem. Sometime when there are more than 1 space between adjacent values, it leads mismatch in the fields and values of the result.
Testing
End to end test:
Verified that every field has correct value.
Command used:
opensearch-benchmark execute-test --workload=http_logs --pipeline=benchmark-only \ --target-hosts=opens-clust-xxx.elb.us-west-2.amazonaws.com:80 \ --include-tasks=delete-index,create-index,check-cluster-health,index-append \ --workload-params='{"index_settings":{"number_of_shards": 1, "number_of_replicas": 1 }}' \ --telemetry=segment-replication-stats --test-modeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.