Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codec Enum to support ZSTD and ZSTDNODICT #327

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

IanHoang
Copy link
Collaborator

@IanHoang IanHoang commented Jun 8, 2023

Description

This PR:

  • Updates OSB to support ZSTD and ZSTDNODICT, two new codecs that are supported since OpenSearch 2.7.0+.
  • Enhance error message to provide list of available codecs
"Please set the value properly for the create-index operation. Invalid index.codec value 'invalid_codec'. Choose from available codecs: ['default', 'best_compression', 'zstd', 'zstdnodict']"

Issues Resolved

#306

Testing

  • New functionality includes testing

Added new tests for ZSTD and ZSTDNODICT. Also added more description to show what available codecs there are for users.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ian Hoang <hoangia@amazon.com>
@IanHoang IanHoang requested a review from gkamat as a code owner June 8, 2023 17:32
Signed-off-by: Ian Hoang <hoangia@amazon.com>
@IanHoang IanHoang merged commit 93d8a8a into opensearch-project:main Jun 12, 2023
@IanHoang IanHoang deleted the new-codecs branch June 27, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants