Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update results_publisher to publisher #316

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Update results_publisher to publisher #316

merged 7 commits into from
Jun 12, 2023

Conversation

IanHoang
Copy link
Collaborator

@IanHoang IanHoang commented May 30, 2023 •
edited
Loading

Description

This PR addresses the following:

  • Updates results_publisher to publisher
  • Updates publishing to reporting
  • Updates README to add documentation link and correct link to CREATE_WORKLOAD_GUIDE.md
  • Updates DEVELOPER_GUIDE.md with important information how to get around conflict with unittests when OSB_DATASTORE_PASSWORD is set.

Issues Resolved

#311
#315

Testing

  • New functionality includes testing
  • Ran make test
  • Ran three benchmark tests -- one with in-memory data store, one with external OpenSearch cluster datastore with password in benchmark.ini, and one with external OpenSearch cluster datastore with password in environment variable. All three succeeded. Confirmed the external datastore tests had data properly ingested.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Ian Hoang added 2 commits May 30, 2023 10:42
Update results_publisher to publisher and update README to reflect do…
f2c321a 
…cumentation and correct link to guide

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Updated DEVELOPER_GUIDE
aa7793c 
Signed-off-by: Ian Hoang <hoangia@amazon.com>
@IanHoang IanHoang requested a review from gkamat as a code owner May 30, 2023 16:08
Ian Hoang added 2 commits May 30, 2023 11:22
Refine DEVELOPER_GUIDE.md
b3d32cd 
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Make sentence edit
1eedde6 
Signed-off-by: Ian Hoang <hoangia@amazon.com>
@IanHoang
Copy link
Collaborator Author

IanHoang commented Jun 6, 2023 •
edited
Loading

Need to update publisher's action of publishing to reporting as stated in this RFC released recently: #324

Update Publisher's action of publishing to reporting
3f7dc0a 
Signed-off-by: Ian Hoang <hoangia@amazon.com>
@IanHoang IanHoang mentioned this pull request Jun 8, 2023
Open
5 tasks
Ian Hoang added 2 commits June 8, 2023 17:23
Update Developer Guide and README conflicts
4c91697 
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Remove section from DEVELOPER_GUIDE
c0fa9fa 
Signed-off-by: Ian Hoang <hoangia@amazon.com>
gkamat
gkamat approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@gkamat gkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a large batch of renames! Looks good but did not explicitly test.

@IanHoang IanHoang merged commit 40ed461 into opensearch-project:main Jun 12, 2023
@IanHoang IanHoang deleted the publishing branch June 27, 2023 15:07
@IanHoang IanHoang mentioned this pull request Aug 3, 2023
Closed
7 tasks
IanHoang pushed a commit to IanHoang/opensearch-benchmark that referenced this pull request Aug 8, 2023
Revert "Update results_publisher to publisher (opensearch-project#316)"
6e964bf 
This reverts commit 40ed461.

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkamat gkamat gkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanHoang @gkamat