Updating integ tests to use current versions of OpenSearch #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Govind Kamat <govkamat@amazon.com>
|
Since you ran tests on Amazon Linux 2, Ubuntu, and MacOS, do you have any findings (tips regarding setup, running tests, or instructions specific to an operating system) that will be useful? If so, it'd be good to update the DEVELOPER_GUIDE.md. We could also have a separate document for Testing alone and just link it in the DEVELOPER_GUIDE.md. |
IanHoang
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The integration tests are currently using obsolete versions of OpenSearch, 1.0.0 and 1.0.1. This updates the versions to the newer ones in the v1 and v2 branches. There is a separate batch of improvements to these tests, which will be checked in post the next OSB release.
Testing
Ran the integ tests on Ubuntu and Amazon Linux 2. All passed.
On Mac, most of the tests passed, but there were occasional timeouts with one of the tests when runs were repeated. This seemed to be the case even prior to these changes, so that will be made more robust separately.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.