Update Dockerfile and Docker README #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users on Dockerhub were having trouble running the command
docker run opensearchproject/opensearch-benchmark
in the README and Dockerhub repo's description. The commands exits with an exit status code of 0 because it doesn't run any entrypoint commands. This PR does the following:Issues Resolved
Testing
Built image locally after updating Dockerfile and tested it with the following commands with Docker CLI. Tested on Docker Desktop to confirm consistency:
docker run --entrypoint bash <IMAGE> -c "opensearch-benchmark -h"
--> overwrites entrypoint commands to use opensearch-benchmark help commanddocker run <IMAGE> opensearch-benchmark -h
--> runs it in simpler methoddocker run -it <IMAGE> /bin/sh
--> runs in interactive mode in terminalBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.