Add fix for git.py to index from the right and reformat branches (#245) #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsearch-project#245) Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
gkamat
approved these changes
Mar 29, 2023
| @@ -121,7 +121,7 @@ def branches(src_dir, remote=True): | |||
| if remote: | |||
| # alternatively: git for-each-ref refs/remotes/ --format='%(refname:short)' | |||
There was a problem hiding this comment.
May want to update this comment, and mention the difference in the behavior of git versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration tests and users using latest versions of
git (2.40.0)experienced issues when using thelistsubcommand or OSB commands that relied onworkloadsrepository. See #245 for more details. When invoking such commands, there would either be connection refused issues orValueError: substring not foundwould appear.This PR applies the fix suggested in the issue #245. See the issue for more details.
Issues Resolved
#245
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.