-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PluginStats with new field in response optional_extended_plugins #814
base: main
Are you sure you want to change the base?
Update PluginStats with new field in response optional_extended_plugins #814
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Changes AnalysisCommit SHA: 0758d80 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13298096671/artifacts/2582663002 API Coverage
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
See tests failing please. Any way we can actually test this field in a response? We have a way to install plugins, you can inspire yourself from https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests/plugins. Update https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml to use 2.19 as stable (replace all 2.18s). Use a 2.20 (even thought there's no plan for such a thing) from dockerhub for the next version. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
There is an existing GET I'll see if I can strengthen the existing assertion. |
Is the default test group supposed to contain tests for knn plugin?
|
Description
A new field was added to the output of the response to
GET _cat/plugins
foroptional_extended_plugins
in 2.19.See opensearch-project/OpenSearch#16909 (comment) and opensearch-project/opensearch-go#669
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.