-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ML Predict, Train APIs #755
Add ML Predict, Train APIs #755
Conversation
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Changes AnalysisCommit SHA: bb1b52b API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12550254156/artifacts/2372208653 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Brilliant job!
I might have made a mistake somewhere since I haven’t worked much with these APIs, but this is an outsider’s perspective.
Thank you for your feedback @Tokesh ! They are really helpful, appreciate it :) |
… defined ML status as an enum, updated ML task state enum, updated CHANGELOG.md. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, fix vale complaints pls? See the diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. Sorry to be annoying, can we please use examples from the movies/books themes? Make up something in that vein (e.g. best sellers in certain years). We plan to use these examples in docs and would like to keep things consistent.
…t and train_predict API, fixed vale complaints. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
@Tokesh You good with this? Re-review/merge pls? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you very much! :)
Happy upcoming New Year!
Description
Added missing ML Predict and Train APIs.
Issues Resolved
Part of opensearch-project/opensearch-py#867.
ML Predict, Train APIs to add
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.