Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing cancellation_time_millis. #747

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Added missing cancellation_time_millis. #747

merged 1 commit into from
Dec 18, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 18, 2024

Description

Added missing cancellation_time_millis.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the cancellation_time_millis branch from 1d30bb6 to 16aebe8 Compare December 18, 2024 16:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Changes Analysis

Commit SHA: f5b8e98
Comparing To SHA: 4c03b59

API Changes

Summary

└─┬Components
  └─┬tasks._common___TaskInfoBase
    └──[➕] properties (59140:9)
Document Element Total Changes Breaking Changes
components 1 0
  • Total Changes: 1
  • Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12397170416/artifacts/2338701992

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@dblock dblock force-pushed the cancellation_time_millis branch 2 times, most recently from 55bde6b to 87fb7ce Compare December 18, 2024 16:26
@dblock
Added missing cancellation_time_millis.
f5b8e98 
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the cancellation_time_millis branch from 87fb7ce to f5b8e98 Compare December 18, 2024 16:26
@github-actions GitHub Actions
Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
536 535 (99.81 %)

@Tokesh Tokesh merged commit 1b6935f into opensearch-project:main Dec 18, 2024
29 checks passed
@dblock dblock deleted the cancellation_time_millis branch December 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tokesh Tokesh Tokesh approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

@Xtansia Xtansia Awaiting requested review from Xtansia Xtansia is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @Tokesh