-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed /_search/scroll/{scroll_id}, missing search tests. #732
Conversation
a56c09a
to
caa8b35
Compare
Changes AnalysisCommit SHA: b3745d4 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12361446786/artifacts/2328624342 API Coverage
|
Spec Test Coverage Analysis
|
ee15f81
to
19e3239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking perfect as usual. It looks like the OS version might need to be updated in one of the tests.
f746863
to
03cbe27
Compare
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
…id}. Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
03cbe27
to
b3745d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM! Great job
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <dblock@amazon.com> * Added tests for GET and POST /_search. Signed-off-by: dblock <dblock@amazon.com> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <dblock@amazon.com> * Added missing _search/point_in_time tests. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com>
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <dblock@amazon.com> * Added tests for GET and POST /_search. Signed-off-by: dblock <dblock@amazon.com> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <dblock@amazon.com> * Added missing _search/point_in_time tests. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <dblock@amazon.com> * Added tests for GET and POST /_search. Signed-off-by: dblock <dblock@amazon.com> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <dblock@amazon.com> * Added missing _search/point_in_time tests. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
…project#732) * Fixed /_search/scroll. Signed-off-by: dblock <dblock@amazon.com> * Added tests for GET and POST /_search. Signed-off-by: dblock <dblock@amazon.com> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <dblock@amazon.com> * Added missing _search/point_in_time tests. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
* Added ML Model APIs (get, search, update model) to the spec along with the tests Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added ML Model APIs (undeploy, unload), moved test for search model to models/search.yaml, resolved conflicts and updated CHANGELOG Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added support for using a certificate and key. (#731) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Fixed /_search/scroll/{scroll_id}, missing search tests. (#732) * Fixed /_search/scroll. Signed-off-by: dblock <dblock@amazon.com> * Added tests for GET and POST /_search. Signed-off-by: dblock <dblock@amazon.com> * Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}. Signed-off-by: dblock <dblock@amazon.com> * Added missing _search/point_in_time tests. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added tests for /_validate/query. (#739) * Added tests for /_validate/query. Signed-off-by: dblock <dblock@amazon.com> * Added retry for #738. Signed-off-by: dblock <dblock@amazon.com> --------- Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Fixed lint and directory path error. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added ML Model APIs (load, upload, create metadata). Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added ML Model APIs (predict) and updated the test settings for metadata. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Fixed lint errors in predict.yaml, moved setup to prologues and teardown to epilogues in predict.yaml and load.yaml, updated CHANGELOG format, updated API description, 'model_group_id' ID type, 'version' parameter, and made 'model_format' a type of its own in ml.yaml. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added ML Model APIs (chunk, register meta), updated CHANGELOG and test for deprecated model metadata creation API. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Added ML Model APIs (upload chunk), moved test for deprecated chunk upload to create_metadata.yaml, updated CHANGELOG. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Applied suggestions from code review. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Merged main and resolve conflicts. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Moved test models folder to tests/plugins/ml/ml/models, removed duplicate map keys in ml._common.yaml, removed excluded parts and until property in the test files. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Fixed merge conflicts, added support for payload properties into the prologue, attempted to fix errors in predict.yaml. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Rebase with main, fixed test-spec.yml content, added response property in prologues of predict.yaml, undeploy.yaml, unload.yaml, added version for ML Model APIs. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> * Modified response payload state from RUNNING to COMPLETED. Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> --------- Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com> Signed-off-by: dblock <dblock@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Description
/_search/scroll/{scroll_id}
deprecated variant does not requirescroll_id
in the body because it's already in the path.GET
andPOST /_search
.GET /_search/pipeline
andDELETE /_search/pipeline/{id}
._search/point_in_time
.Issues Resolved
Part of #663.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.