Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed /_search/scroll/{scroll_id}, missing search tests. #732

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 13, 2024

Description

  • The /_search/scroll/{scroll_id} deprecated variant does not require scroll_id in the body because it's already in the path.
  • Tests for GET and POST /_search.
  • Tests for GET /_search/pipeline and DELETE /_search/pipeline/{id}.
  • Tests for remainder of _search/point_in_time.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Changes Analysis

Commit SHA: b3745d4
Comparing To SHA: b2c8c46

API Changes

Summary

└─┬Paths
  ├─┬/_search/scroll/{scroll_id}
  │ ├─┬GET
  │ │ └─┬Requestbody
  │ │   └─┬application/json
  │ │     └─┬Schema
  │ │       ├──[➖] required (27470:17)❌ 
  │ │       └──[➖] description (27471:26)
  │ └─┬POST
  │   └─┬Requestbody
  │     └─┬application/json
  │       └─┬Schema
  │         ├──[➖] required (27470:17)❌ 
  │         └──[➖] description (27471:26)
  └─┬/_search/scroll
    ├─┬GET
    │ └─┬Requestbody
    │   └─┬application/json
    │     └─┬Schema
    │       ├──[➖] required (27470:17)❌ 
    │       └──[➖] description (27471:26)
    └─┬POST
      └─┬Requestbody
        └─┬application/json
          └─┬Schema
            ├──[➖] required (27470:17)❌ 
            └──[➖] description (27471:26)

Document Element Total Changes Breaking Changes
paths 8 4
  • BREAKING Changes: 4 out of 8
  • Removals: 8
  • Breaking Removals: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12361446786/artifacts/2328624342

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@dblock dblock changed the title Fixed /_search/scroll. Fixed /_search/scroll/{scroll_id}. Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Spec Test Coverage Analysis

Total Tested
536 506 (94.4 %)

@dblock dblock changed the title Fixed /_search/scroll/{scroll_id}. Fixed /_search/scroll/{scroll_id}, missing search tests. Dec 13, 2024
Copy link
Collaborator

@Tokesh Tokesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking perfect as usual. It looks like the OS version might need to be updated in one of the tests.

tests/default/_core/search/pipeline.yaml Outdated Show resolved Hide resolved
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
…id}.

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Copy link
Collaborator

@Tokesh Tokesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM! Great job

@dblock dblock merged commit 1bae571 into opensearch-project:main Dec 17, 2024
30 checks passed
@dblock dblock deleted the search-scroll branch December 17, 2024 13:10
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Dec 17, 2024
…project#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <dblock@amazon.com>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <dblock@amazon.com>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <dblock@amazon.com>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Dec 18, 2024
…project#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <dblock@amazon.com>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <dblock@amazon.com>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <dblock@amazon.com>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Jan 7, 2025
…project#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <dblock@amazon.com>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <dblock@amazon.com>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <dblock@amazon.com>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Jan 9, 2025
…project#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <dblock@amazon.com>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <dblock@amazon.com>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <dblock@amazon.com>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
dblock added a commit that referenced this pull request Jan 9, 2025
* Added ML Model APIs (get, search, update model) to the spec along with the tests

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added ML Model APIs (undeploy, unload), moved test for search model to models/search.yaml, resolved conflicts and updated CHANGELOG

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added support for using a certificate and key. (#731)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Fixed /_search/scroll/{scroll_id}, missing search tests. (#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <dblock@amazon.com>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <dblock@amazon.com>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <dblock@amazon.com>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added tests for /_validate/query. (#739)

* Added tests for /_validate/query.

Signed-off-by: dblock <dblock@amazon.com>

* Added retry for #738.

Signed-off-by: dblock <dblock@amazon.com>

---------

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Fixed lint and directory path error.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added ML Model APIs (load, upload, create metadata).

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added ML Model APIs (predict) and updated the test settings for metadata.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Fixed lint errors in predict.yaml, moved setup to prologues and teardown to epilogues in predict.yaml and load.yaml, updated CHANGELOG format, updated API description, 'model_group_id' ID type, 'version' parameter, and made 'model_format' a type of its own in ml.yaml.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added ML Model APIs (chunk, register meta), updated CHANGELOG and test for deprecated model metadata creation API.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Added ML Model APIs (upload chunk), moved test for deprecated chunk upload to create_metadata.yaml, updated CHANGELOG.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Applied suggestions from code review.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Merged main and resolve conflicts.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Moved test models folder to tests/plugins/ml/ml/models, removed duplicate map keys in ml._common.yaml, removed excluded parts and until property in the test files.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Fixed merge conflicts, added support for payload properties into the prologue, attempted to fix errors in predict.yaml.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Rebase with main, fixed test-spec.yml content, added response property in prologues of predict.yaml, undeploy.yaml, unload.yaml, added version for ML Model APIs.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

* Modified response payload state from RUNNING to COMPLETED.

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>

---------

Signed-off-by: Nathalie Jonathan <nathhjo@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants