-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues for termsQuery #570
Conversation
@amberzsy Are you able to provide an example (i.e. dashboards dev tools |
Changes AnalysisCommit SHA: ab96677 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10879001532/artifacts/1937465581 API Coverage
|
Spec Test Coverage Analysis
|
|
Tests failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the tests
Signed-off-by: amberzsy <xxamber998@gmail.com>
Signed-off-by: amberzsy <xxamber998@gmail.com>
…as boost/_name not valid 3. add TermsLookup test Signed-off-by: amberzsy <xxamber998@gmail.com>
8e76470
to
cbe3baf
Compare
Signed-off-by: amberzsy <xxamber998@gmail.com>
done. fix ^^ issue in latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The linter failed, run npm run lint--fix
.
Signed-off-by: amberzsy <xxamber998@gmail.com>
Signed-off-by: amberzsy <xxamber998@gmail.com>
Description
couple of issues here:
should be simplified with oneOf.
5. incorrect definition for terms look up query, boost is not valid field so should not have QueryBase as part of TermsQuery here
Issues Resolved
fixes #540
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.