Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed/added ISM APIs. #568

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fixed/added ISM APIs. #568

merged 2 commits into from
Sep 13, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 10, 2024

Description

I was curious about the 26 "specified_but_not_provided" endpoints that surface in our coverage report, starting with the /_plugins/_transform/_preview API. This one has the wrong verb (and other problems), so I began fixing it.

  • Fix /_plugins/_transform/_preview, needs a body, has the wrong verb.
  • Added ISM CRUD APIs. I spent some time in the ISM plugin code to extract some of these, so likely several aspects missing that we can fix as we go.

Issues Resolved

Part of #224.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Changes Analysis

Commit SHA: 7c2ff32
Comparing To SHA: d05ba73

API Changes

Summary

├─┬Paths
│ ├──[➕] path (11485:3)
│ ├──[➕] path (11607:3)
│ ├──[➕] path (3850:3)
│ ├──[➕] path (11546:3)
│ ├──[➕] path (11506:3)
│ ├──[➕] path (3740:3)
│ ├──[➕] path (11527:3)
│ ├──[➕] path (3778:3)
│ ├──[➕] path (3795:3)
│ ├──[➕] path (3759:3)
│ └─┬/_plugins/_transform/_preview
│   ├──[➖] get (6714:7)❌ 
│   └──[➕] post (6841:7)
└─┬Components
  ├──[➕] requestBodies (25819:7)
  ├──[➕] requestBodies (24936:7)
  ├──[➕] requestBodies (24946:7)
  ├──[➕] requestBodies (24941:7)
  ├──[➕] responses (27366:7)
  ├──[➕] responses (27336:7)
  ├──[➕] responses (27361:7)
  ├──[➕] responses (27356:7)
  ├──[➕] responses (27371:7)
  ├──[➕] responses (27341:7)
  ├──[➕] responses (27346:7)
  ├──[➕] responses (27351:7)
  ├──[➕] parameters (20442:7)
  ├──[➕] parameters (20464:7)
  ├──[➕] parameters (20436:7)
  ├──[➕] parameters (20426:7)
  ├──[➕] parameters (20478:7)
  ├──[➕] parameters (20471:7)
  ├──[➕] parameters (20452:7)
  ├──[➕] parameters (20416:7)
  ├──[➕] parameters (20458:7)
  ├──[➕] schemas (49184:7)
  ├──[➕] schemas (48995:7)
  ├──[➕] schemas (49122:7)
  ├──[➕] schemas (48911:7)
  ├──[➕] schemas (49254:7)
  ├──[➕] schemas (49032:7)
  ├──[➕] schemas (49231:7)
  ├──[➕] schemas (49173:7)
  ├──[➕] schemas (49099:7)
  ├──[➕] schemas (49056:7)
  ├──[➕] schemas (48997:7)
  ├──[➕] schemas (49029:7)
  ├──[➕] schemas (48980:7)
  ├──[➕] schemas (49275:7)
  ├──[➕] schemas (49049:7)
  ├──[➕] schemas (49071:7)
  ├──[➕] schemas (49026:7)
  ├──[➕] schemas (49129:7)
  ├──[➕] schemas (48953:7)
  ├──[➕] schemas (49104:7)
  ├──[➕] schemas (48959:7)
  ├──[➕] schemas (48975:7)
  ├──[➕] schemas (49058:7)
  ├──[➕] schemas (49222:7)
  ├──[➕] schemas (48985:7)
  ├──[➕] schemas (48999:7)
  ├──[➕] schemas (48990:7)
  ├──[➕] schemas (49153:7)
  ├──[➕] schemas (48978:7)
  ├──[➕] schemas (49089:7)
  ├──[➕] schemas (49229:7)
  ├──[➕] schemas (49013:7)
  ├──[➕] schemas (49046:7)
  ├──[➕] schemas (49157:7)
  ├──[➕] schemas (48993:7)
  ├──[➕] schemas (49087:7)
  ├──[➕] schemas (49144:7)
  ├──[➕] schemas (49220:7)
  ├──[➕] schemas (49004:7)
  ├──[➕] schemas (49162:7)
  ├──[➕] schemas (49082:7)
  ├──[➕] schemas (49115:7)
  ├──[➕] schemas (49215:7)
  ├──[➕] schemas (48973:7)
  └──[➕] schemas (49041:7)

Document Element Total Changes Breaking Changes
paths 12 1
components 66 0
  • BREAKING Changes: 1 out of 78
  • Removals: 1
  • Additions: 77
  • Breaking Removals: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10847624552/artifacts/1929293379

API Coverage

Before After Δ
Covered (%) 545 (53.38 %) 560 (54.85 %) 15 (1.47 %)
Uncovered (%) 476 (46.62 %) 461 (45.15 %) -15 (-1.47 %)
Unknown 26 25 -1

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Spec Test Coverage Analysis

Total Tested
585 290 (49.57 %)

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the ism-apis branch 4 times, most recently from 1cca095 to 3ee472d Compare September 13, 2024 09:26
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock marked this pull request as ready for review September 13, 2024 10:40
@dblock dblock changed the title Fix: ISM APIs. Fixed/added ISM APIs. Sep 13, 2024
@nhtruong nhtruong merged commit c2c666f into opensearch-project:main Sep 13, 2024
28 checks passed
@dblock dblock deleted the ism-apis branch September 13, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants