Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terms query schema #564

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Sep 9, 2024

Description

Fixes missing additionalProperties and location of oneOf in terms query

Issues Resolved

Fixes #540

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Changes Analysis

Commit SHA: 0cb1c2f
Comparing To SHA: a768a73

API Changes

Summary

└─┬Components
  ├──[➖] schemas (38785:7)❌ 
  ├─┬_common.query_dsl:TermsSetQuery
  │ └─┬ALLOF
  │   └─┬terms
  │     └──[🔀] $ref (38815:15)❌ 
  ├─┬_common.query_dsl:TermsQuery
  │ └─┬ANYOF
  │   └──[🔀] $ref (38795:11)❌ 
  └─┬_common.query_dsl:QueryContainer
    └─┬terms
      └──[🔀] $ref (38276:11)❌ 

Document Element Total Changes Breaking Changes
components 4 5
  • BREAKING Changes: 5 out of 4
  • Modifications: 3
  • Removals: 1
  • Breaking Removals: 1
  • Breaking Modifications: 3

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10783139802/artifacts/1911763393

API Coverage

Before After Δ
Covered (%) 537 (52.6 %) 537 (52.6 %) 0 (0 %)
Uncovered (%) 484 (47.4 %) 484 (47.4 %) 0 (0 %)
Unknown 26 26 0

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Spec Test Coverage Analysis

Total Tested
563 271 (48.13 %)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia marked this pull request as ready for review September 9, 2024 23:54
@dblock dblock merged commit 3dcced9 into opensearch-project:main Sep 10, 2024
25 checks passed
@Xtansia Xtansia deleted the fix/terms-query branch September 10, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] missing definition in termsQuery
2 participants