Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create-index blocked solution and switch to npm ci #465

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

awick
Copy link
Contributor

@awick awick commented Aug 5, 2024

Description

  • Added a solution for the cluster create-index blocked error when hitting disk thresholds which is more likely when testing on local laptops
  • updated doc to use npm ci instead of npm install so that developers will use package lock file provided

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andy Wick <andywick@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Changes Analysis

Commit SHA: 2c59109
Comparing To SHA: c0d4a85

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10254689117/artifacts/1777857406

API Coverage

Before After Δ
Covered (%) 510 (49.95 %) 510 (49.95 %) 0 (0 %)
Uncovered (%) 511 (50.05 %) 511 (50.05 %) 0 (0 %)
Unknown 24 24 0

Signed-off-by: Andy Wick <andywick@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, update TOC please.

Does it make sense to execute this for all tests all the time? This could go into docker-compose or as a step in the tests?

@@ -41,7 +41,28 @@ Verbose output:
npm run test:spec -- --opensearch-insecure --verbose
```

Note: Remember to set the `OPENSEARCH_PASSWORD` environment variable everytime you start a new shell to run the tests. Failing to do so will result in 401 Unauthorized errors.
### Common Errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update TOC?

awick added 2 commits August 5, 2024 15:07
Signed-off-by: Andy Wick <andywick@amazon.com>
Signed-off-by: Andy Wick <andywick@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Spec Test Coverage Analysis

Total Tested
534 118 (22.1 %)

@dblock dblock merged commit 21bd106 into opensearch-project:main Aug 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants