-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create-index blocked solution and switch to npm ci #465
Add create-index blocked solution and switch to npm ci #465
Conversation
Signed-off-by: Andy Wick <andywick@amazon.com>
Changes AnalysisCommit SHA: 2c59109 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10254689117/artifacts/1777857406 API Coverage
|
Signed-off-by: Andy Wick <andywick@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, update TOC please.
Does it make sense to execute this for all tests all the time? This could go into docker-compose or as a step in the tests?
@@ -41,7 +41,28 @@ Verbose output: | |||
npm run test:spec -- --opensearch-insecure --verbose | |||
``` | |||
|
|||
Note: Remember to set the `OPENSEARCH_PASSWORD` environment variable everytime you start a new shell to run the tests. Failing to do so will result in 401 Unauthorized errors. | |||
### Common Errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update TOC?
Signed-off-by: Andy Wick <andywick@amazon.com>
Signed-off-by: Andy Wick <andywick@amazon.com>
Spec Test Coverage Analysis
|
Description
cluster create-index blocked
error when hitting disk thresholds which is more likely when testing on local laptopsnpm ci
instead ofnpm install
so that developers will use package lock file providedIssues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.