-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output a warning on mulitple paths being tested in the same file. #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
warn-multiple-paths
branch
from
July 29, 2024 20:25
297edcc
to
2b6a10c
Compare
Spec Test Coverage Analysis
|
Changes AnalysisCommit SHA: df9e41a API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10205196222/artifacts/1766570560 API Coverage
|
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
July 29, 2024 21:47
nhtruong
reviewed
Jul 30, 2024
dblock
force-pushed
the
warn-multiple-paths
branch
from
July 30, 2024 21:27
b41c0a1
to
41c11c7
Compare
nhtruong
previously approved these changes
Jul 31, 2024
dblock
force-pushed
the
warn-multiple-paths
branch
from
July 31, 2024 19:02
41c11c7
to
3c22d39
Compare
@nhtruong rebased |
dblock
force-pushed
the
warn-multiple-paths
branch
from
July 31, 2024 20:00
3c22d39
to
f77f03d
Compare
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
warn-multiple-paths
branch
from
August 1, 2024 20:20
f77f03d
to
df9e41a
Compare
Xtansia
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for story warnings, outputs a warning when multiple paths are being tested.
This lets us catch the instances where we maybe be testing multiple/unrelated paths or where some should be in prologue. It helps make tests more contained, and warnings can be suppressed when absolutely necessary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.