Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rudimentary test coverage counting paths being tested. #443

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 19, 2024

Description

Adds rudimentary test coverage. Not quite codecov integration, but it's a start ;) Counts the total number of paths in the spec vs. the number of paths being tested by test runner, takes the max from the runs against multiple version of OpenSearch. Appends a coverage analysis using the existing PR comment mechanism.

Demo in dblock#13.

Screenshot 2024-07-19 at 6 22 16 PM

Issues Resolved

Closes #406.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Changes Analysis

Commit SHA: e65d0eb
Comparing To SHA: d8f1e02

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10042704025/artifacts/1726204581

API Coverage

Before After Δ
Covered (%) 490 (47.99 %) 490 (47.99 %) 0 (0 %)
Uncovered (%) 531 (52.01 %) 531 (52.01 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the test-coverage branch 19 times, most recently from f13fa2c to aeecdc2 Compare July 19, 2024 22:12
@dblock dblock changed the title Added test coverage. Added rudimentary test coverage counting paths being tested. Jul 19, 2024
@dblock dblock marked this pull request as ready for review July 19, 2024 22:22
Signed-off-by: dblock <dblock@amazon.com>
dblock added 4 commits July 22, 2024 10:23
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@nhtruong nhtruong merged commit 34ff292 into opensearch-project:main Jul 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add test spec coverage
2 participants