spec: add plugins to NodeInfoSettings

[Jakob3xD]

Description

Add plugins to NodeInfoSettings

Issues Resolved

Closes #441

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

Thanks! Care to add a test that has a response with this field?

[github-actions]

Changes Analysis

Commit SHA: f37796c
Comparing To SHA: e1cd369

API Changes

Summary

└─┬Components
  ├──[➕] schemas (46554:7)
  └─┬nodes.info:NodeInfoSettings
    └──[➕] properties (46391:9)

Document Element	Total Changes	Breaking Changes
components	2	0

• Total Changes: 2
• Additions: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10009680557/artifacts/1719412447

API Coverage

	Before	After	Δ
Covered (%)	490 (47.99 %)	490 (47.99 %)	0 (0 %)
Uncovered (%)	531 (52.01 %)	531 (52.01 %)	0 (0 %)
Unknown	24	24	0

[Jakob3xD]

Thanks! Care to add a test that has a response with this field?

I am not quite sure how to do this as the response contains as map with a random node id.

But I added the option to the docker env that is responsible for the plugins property to show up.

[dblock]

I am not quite sure how to do this as the response contains as map with a random node id.

You don't actually need to verify the content. As long as the response has the missing field it will validate it against the spec. Try without the fix and it should fail - I imagine with the change to the docker options it's failing now? With the fix it will pass.

[Jakob3xD]

You don't actually need to verify the content. As long as the response has the missing field it will validate it against the spec. Try without the fix and it should fail - I imagine with the change to the docker options it's failing now? With the fix it will pass.

Yup, fails without the plugins.
https://github.com/Jakob3xD/opensearch-api-specification/actions/runs/10036637738/job/27734769941

[dblock]

Merged, thank you!

[dblock]

@Jakob3xD why did we add plugins.index_state_management.job_interval=1 here?

[Jakob3xD]

@Jakob3xD why did we add plugins.index_state_management.job_interval=1 here?

The setting gets returned on node info calls. With this it gets returned by the api and we can test against it. Otherwise it would be omitted.

[dblock]

Can it be set via an API like here? I am thinking we need some way to set and unset these and other settings across tests.

[dblock]

I tried to do this in #471 in which I added a test that ensures the response contains the job_interval value. You can set cluster settings, but it has no effect on the response from nodes unfortunately. There's no way to set a node setting via API.