-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geodistance query test #427
Conversation
Changes AnalysisCommit SHA: 1781882 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9991180978/artifacts/1714903071 API Coverage
|
@nhtruong @Xtansia @dblock This is my first spec test so please bear with me :) The geodistance query requires a field from which to measure the distance. This field must be a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few asks.
This is really search, and we'll have more, so let's make a new folder tests/_core/search
, and call this file geo_distance.yaml
to match the query type? If you want to break up search.yaml
along those lines in the same PR go for it too, otherwise I can do it later.
@@ -625,8 +625,16 @@ components: | |||
$ref: '_common.yaml#/components/schemas/GeoDistanceType' | |||
validation_method: | |||
$ref: '#/components/schemas/GeoValidationMethod' | |||
ignore_unmapped: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to CHANGELOG. This is a new field added.
Do you know which version this new option was added in? Might need x-added-...
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this field has been inherited since 1.0. Is there an easy way to make sure (other than running the query against 1.0 :)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually look at code. We now have 1.3.x tests here, so this will fail if it didn't exist.
@dblock Thanks for reviewing. I addressed your comments. |
@kolchfa-aws Can you please rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs a rebase.
@@ -625,8 +625,16 @@ components: | |||
$ref: '_common.yaml#/components/schemas/GeoDistanceType' | |||
validation_method: | |||
$ref: '#/components/schemas/GeoValidationMethod' | |||
ignore_unmapped: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually look at code. We now have 1.3.x tests here, so this will fail if it didn't exist.
director: Bennett Miller | ||
title: Moneyball | ||
year: 2011 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of empty trailing line.
Looks like you figured out a workaround by putting this in the prologue? LMK if you still need help. |
Looks like there are still unrelated changes and a missing DCO. LMK if you need help. |
75ca8d6
to
dcbe940
Compare
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
dcbe940
to
71b9e3a
Compare
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Description
Adds a spec test for the geodistance query
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.