-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for application/smile #386
Conversation
Changes AnalysisCommit SHA: ab88a52 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9865817894/artifacts/1684368883 API Coverage
|
tests/cat/health.yaml
Outdated
format: smile | ||
response: | ||
status: 200 | ||
content_type: application/yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not actually validating content_type
against the response content-type header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it, #392.
- synopsis: This GET /_cat/health chapter returns application/smile and should pass. | ||
path: /_cat/health | ||
parameters: | ||
format: cbor | ||
method: GET | ||
response: | ||
status: 200 | ||
content_type: application/smile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above regarding validating content_type
as test is supposed to be for smile
but format is set to cbor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to be format: smile
.
Signed-off-by: dblock <dblock@amazon.com>
Description
Add support for application/smile.
Thanks to @ngyewch for the recent work on the smile-js library to get this over the line!
Issues Resolved
Closes #372.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.