Add test

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
opensearch-project · Sep 9, 2024 · dec5cc6 · dec5cc6
1 parent f322d70
commit dec5cc6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/tools/src/_utils/JsonSchemaValidator.ts b/tools/src/_utils/JsonSchemaValidator.ts
@@ -42,7 +42,7 @@ export default class JsonSchemaValidator {
       try {
         this.ajv.addSchema(schema, key);
       } catch (e) {
-        throw new Error(`Failed to add schema ${key}: \`${JSON.stringify(schema)}\``, { cause: e })
+        throw new Error(`Failed to add schema ${key} (${JSON.stringify(schema)}):\n\t${e instanceof Error ? e.message : e as string}`)
       }
     })
     this.errors_parser = new AjvErrorsParser(this.ajv, options.errors_text_opts)

diff --git a/tools/tests/_utils/JsonSchemaValidator.test.ts b/tools/tests/_utils/JsonSchemaValidator.test.ts
@@ -83,4 +83,17 @@ describe('JsonSchemaValidator', () => {
 
     expect(validator.validate_schema(invalid_schema)).toEqual('data/required must be array');
   });
+
+  test('constructing with invalid reference schema throws descriptive error', () => {
+    const invalid_options = {
+      reference_schemas: {
+        '#/components/schemas/Invalid': {
+          type: 'string',
+          required: true, // required must be an array
+        }
+      }
+    }
+    expect(() => new JsonSchemaValidator(schema, invalid_options))
+      .toThrow('Failed to add schema #/components/schemas/Invalid ({"type":"string","required":true}):\n\tschema is invalid: data/required must be array');
+  });
 });