Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove months and quarters from span interval #1257

Merged
merged 1 commit into from
Nov 4, 2022
Merged

remove months and quarters from span interval #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboards-observability/common/constants/metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const resolutionOptions = [
{ value: 'm', text: 'minutes' },
{ value: 'h', text: 'hours' },
{ value: 'd', text: 'days' },
{ value: 'M', text: 'Months' },
{ value: 'q', text: 'quarters' },
// { value: 'M', text: 'Months' },
// { value: 'q', text: 'quarters' },
Comment on lines +20 to +21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need it for now. .

{ value: 'y', text: 'years' },
];

Expand Down
12 changes: 6 additions & 6 deletions ...rvability/public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -197,7 +197,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down Expand Up @@ -230,7 +230,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -302,7 +302,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down Expand Up @@ -335,7 +335,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -407,7 +407,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down
108 changes: 0 additions & 108 deletions ...ability/public/components/metrics/top_menu/__tests__/__snapshots__/top_menu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,14 +274,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -323,14 +315,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -396,14 +380,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -465,18 +441,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
</option>
<option
key="4"
value="M"
>
Months
</option>
<option
key="5"
value="q"
>
quarters
</option>
<option
key="6"
value="y"
>
years
Expand Down Expand Up @@ -1631,14 +1595,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -1680,14 +1636,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -1753,14 +1701,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -1822,18 +1762,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
</option>
<option
key="4"
value="M"
>
Months
</option>
<option
key="5"
value="q"
>
quarters
</option>
<option
key="6"
value="y"
>
years
Expand Down Expand Up @@ -2934,14 +2862,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -2983,14 +2903,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -3056,14 +2968,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -3125,18 +3029,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
</option>
<option
key="4"
value="M"
>
Months
</option>
<option
key="5"
value="q"
>
quarters
</option>
<option
key="6"
value="y"
>
years
Expand Down