internal review comments resolved

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
opensearch-project · Sep 30, 2022 · 3fb0130 · 3fb0130
1 parent 9da652c
commit 3fb0130
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 17 deletions.
diff --git a/...lorer/visualizations/config_panel/config_panes/config_controls/config_treemap_parents.tsx b/...lorer/visualizations/config_panel/config_panes/config_controls/config_treemap_parents.tsx
@@ -5,7 +5,7 @@
 
 import { EuiButtonIcon, EuiPanel, EuiSpacer, EuiText } from '@elastic/eui';
 import { isEmpty } from 'lodash';
-import React from 'react';
+import React, { Fragment } from 'react';
 import { ParentUnitType } from '../../../../../../../../common/types/explorer';
 
 export const ConfigTreemapParentFields = ({
@@ -42,9 +42,9 @@ export const ConfigTreemapParentFields = ({
       {!isEmpty(selectedAxis) &&
         selectedAxis.map((obj: ParentUnitType, index: number) => {
           return (
-            <>
+            <Fragment key={index}>
               <EuiSpacer size="s" />
-              <EuiPanel key={index} paddingSize="s" className="panelItem_button">
+              <EuiPanel paddingSize="s" className="panelItem_button">
                 <EuiText size="s" className="field_text" onClick={() => handleEditParent(index)}>
                   <a role="button" tabIndex={0}>
                     {obj.label !== '' ? obj.label : `Parent ${index + 1}`}
@@ -58,7 +58,7 @@ export const ConfigTreemapParentFields = ({
                   onClick={() => handleParentDelete(index)}
                 />
               </EuiPanel>
-            </>
+            </Fragment>
           );
         })}
       <EuiSpacer size="s" />

diff --git a/...rer/visualizations/config_panel/config_panes/config_controls/data_config_panel_fields.tsx b/...rer/visualizations/config_panel/config_panes/config_controls/data_config_panel_fields.tsx
@@ -2,7 +2,7 @@
  * Copyright OpenSearch Contributors
  * SPDX-License-Identifier: Apache-2.0
  */
-import React from 'react';
+import React, { Fragment } from 'react';
 import { EuiButtonIcon, EuiPanel, EuiSpacer, EuiText, EuiTitle } from '@elastic/eui';
 import { ConfigListEntry } from '../../../../../../../../common/types/explorer';
 import { VIS_CHART_TYPES } from '../../../../../../../../common/constants/shared';
@@ -37,8 +37,8 @@ export const DataConfigPanelFields = ({
       <EuiSpacer size="s" />
       {list !== undefined &&
         list.map((obj: ConfigListEntry, index: number) => (
-          <>
-            <EuiPanel key={index} paddingSize="s" className="panelItem_button">
+          <Fragment key={index}>
+            <EuiPanel paddingSize="s" className="panelItem_button">
               <EuiText
                 size="s"
                 className="field_text"
@@ -58,7 +58,7 @@ export const DataConfigPanelFields = ({
               />
             </EuiPanel>
             <EuiSpacer size="s" />
-          </>
+          </Fragment>
         ))}
       {!isHeatMapAddButton(sectionName) && (
         <EuiPanel className="panelItem_button" grow>

diff --git a/...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx b/...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
@@ -20,7 +20,6 @@ import {
   htmlIdGenerator,
   EuiToolTip,
 } from '@elastic/eui';
-import React, { useCallback, useContext, useEffect, useMemo, useState } from 'react';
 import { batch, useDispatch } from 'react-redux';
 import {
   AGGREGATIONS,
@@ -30,7 +29,6 @@ import {
   RAW_QUERY,
   TIMESTAMP,
   TIME_INTERVAL_OPTIONS,
-  CUSTOM_LABEL,
 } from '../../../../../../../../common/constants/explorer';
 import { VIS_CHART_TYPES } from '../../../../../../../../common/constants/shared';
 import { composeAggregations } from '../../../../../../../../common/query_manager/utils';
@@ -269,7 +267,7 @@ export const DataConfigPanelItem = ({
     const isDimensions = name === GROUPBY;
     return (
       <>
-        <div key={index} className="services">
+        <div className="services">
           <div className="first-division">
             <DataConfigItemClickPanel
               isSecondary
@@ -332,7 +330,8 @@ export const DataConfigPanelItem = ({
           </div>
         </div>
       </>
-  );
+    );
+  };
 
   const getCommonDimensionsField = (selectedObj: ConfigListEntry, name: string) => (
     <EuiFormRow label="Field">

diff --git a/...er/visualizations/config_panel/config_panes/config_controls/treemap_config_panel_item.tsx b/...er/visualizations/config_panel/config_panes/config_controls/treemap_config_panel_item.tsx
@@ -25,7 +25,6 @@ import {
   PARENTFIELDS,
   VALUEFIELD,
 } from '../../../../../../../../common/constants/explorer';
-import { DataConfigPanelProps } from '../../../../../../../../common/types/explorer';
 import { TabContext } from '../../../../../hooks';
 import { ConfigTreemapParentFields } from './config_treemap_parents';
 import { DataConfigItemClickPanel } from './data_config_item_click_panel';
@@ -148,7 +147,7 @@ export const TreemapConfigPanelItem = ({
           placeholder="Select a field"
           options={options}
           selectedOptions={selectedAxis[index].label !== '' ? [selectedAxis[index]] : []}
-          isClearable={true}
+          isClearable
           singleSelection={{ asPlainText: true }}
           onChange={handleParentChange}
           aria-label="Parent field"

diff --git a/dashboards-observability/public/components/visualizations/charts/helpers/viz_types.ts b/dashboards-observability/public/components/visualizations/charts/helpers/viz_types.ts
@@ -19,7 +19,6 @@ import {
   GROUPBY,
   PARENTFIELDS,
   TIME_INTERVAL_OPTIONS,
-  CUSTOM_LABEL,
 } from '../../../../../common/constants/explorer';
 interface IVizContainerProps {
   vizId: string;
@@ -183,8 +182,8 @@ const getUserConfigs = (
                 childField: { ...(axesData.xaxis ? axesData.xaxis[0] : initialEntryTreemap) },
                 parentFields:
                   userSelectedConfigs?.dataConfig !== undefined &&
-                  userSelectedConfigs?.dataConfig[GROUPBY]?.length > 0
-                    ? [...userSelectedConfigs?.dataConfig[GROUPBY][0][PARENTFIELDS]]
+                  userSelectedConfigs.dataConfig[GROUPBY]?.length > 0
+                    ? [...userSelectedConfigs.dataConfig[GROUPBY][0][PARENTFIELDS]]
                     : [],
               },
             ],