Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of allowedConfigFeatures #387

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Mar 24, 2022

Description

Related common-utils PR: opensearch-project/common-utils#144

  • Removes allowedConfigFeatures from the GetPluginFeaturesResponse to reflect the common-utils changes
  • Removes allowedConfigFeatures from NotificationCore core interface in spi
  • Removes the allowedConfigFeatures plugin setting

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

qreshi added 2 commits March 24, 2022 00:56
…ationCore interface

Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
@qreshi qreshi requested a review from a team March 24, 2022 21:16
@codecov-commenter
Copy link

Codecov Report

Merging #387 (1426c8b) into main (9f31061) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          51       51           
  Lines        1479     1479           
  Branches      352      352           
=======================================
  Hits         1278     1278           
  Misses        198      198           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f31061...1426c8b. Read the comment docs.

@adityaj1107
Copy link
Contributor

Changes in common-utils for GetPluginFeaturesResponse merged here: opensearch-project/common-utils#144

@qreshi qreshi merged commit bc4369a into opensearch-project:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants