Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade BWC version and fix neural search build #868

Merged

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Aug 20, 2024

Description

This PR contains couple of things.

  1. Fixing Neural Search build by encompassing latest KNN changes.
  2. Increasing BWC version to 2.17.0-SNAPSHOT

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <varunudr@amazon.com>
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@vibrantvarun vibrantvarun merged commit 03d528e into opensearch-project:main Aug 20, 2024
53 of 69 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-868-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03d528ee6567087f7cad9e637bd1192aaefe4a5a
# Push it to GitHub
git push --set-upstream origin backport/backport-868-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-868-to-2.x.

vibrantvarun added a commit to vibrantvarun/neural-search that referenced this pull request Aug 21, 2024
Signed-off-by: Varun Jain <varunudr@amazon.com>
vibrantvarun added a commit that referenced this pull request Aug 21, 2024
* Upgrade BWC version and fix neural search build (#868)

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Incrementing opensearch version to 2.17.0-SNAPSHOT

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Incorporate fix from opensearch-project/OpenSearch#15238 from OpenSearch Core

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Address Naveen's comment

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants