Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower bounds for min-max normalization in hybrid query, feature->main #1213

Merged

Conversation

martin-gaievski
Copy link
Member

Description

Moving lower_bounds from feature branch to main after getting clearance from app sec team. Include following PRs:

Related Issues

#150
Implemented design described in RFC #1189
PR for adding documentation: opensearch-project/documentation-website#9337

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ry (#1195)

* Working draft with unit tests
* Added integ test, adjust some calculations

---------

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 83.85417% with 31 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (9cc8959) to head (3a6eab3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...search/neuralsearch/processor/CompoundTopDocs.java 55.55% 8 Missing and 12 partials ⚠️
...rmalization/MinMaxScoreNormalizationTechnique.java 92.92% 2 Missing and 5 partials ⚠️
...rocessor/normalization/ScoreNormalizationUtil.java 89.47% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1213      +/-   ##
============================================
+ Coverage     81.77%   81.79%   +0.02%     
- Complexity     2512     2606      +94     
============================================
  Files           190      190              
  Lines          8564     8922     +358     
  Branches       1436     1520      +84     
============================================
+ Hits           7003     7298     +295     
- Misses         1003     1034      +31     
- Partials        558      590      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martin-gaievski martin-gaievski merged commit 4430ec1 into main Mar 6, 2025
113 checks passed
@martin-gaievski martin-gaievski deleted the feature/lower_bounds_for_minmax_normalization branch March 6, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants