Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Optimize ML inference connection retry logic #1058

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4c119f0 from #1054

@junqiu-lei
Copy link
Member

junqiu-lei commented Jan 4, 2025

CI failed due to Randomness.get().nextLong(int,int) not avaliable in 2.x OpenSearch:

> Task :compileJava FAILED
/Users/junqiu/dev/neural-search/src/main/java/org/opensearch/neuralsearch/util/RetryUtil.java:62: error: method nextLong in class Random cannot be applied to given types;
        long jitter = Randomness.get().nextLong(10, 50); // Add jitter between 10ms and 50ms
                                      ^
  required: no arguments
  found:    int,int
  reason: actual and formal argument lists differ in length
Note: /Users/junqiu/dev/neural-search/src/main/java/org/opensearch/neuralsearch/processor/combination/ScoreCombinationUtil.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

Manually raised another backport PR #1059 to fix this issue for 2.x.

@junqiu-lei junqiu-lei closed this Jan 4, 2025
@peterzhuamazon peterzhuamazon deleted the backport/backport-1054-to-2.x branch January 21, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants