bump 2.8 to unblock 2.8 release #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #896 +/- ##
============================================
- Coverage 84.18% 84.17% -0.01%
Complexity 1764 1764
============================================
Files 139 139
Lines 6780 6776 -4
Branches 676 676
============================================
- Hits 5708 5704 -4
Misses 774 774
Partials 298 298
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b4sjoo
reviewed
May 18, 2023
common/build.gradle
Outdated
| xml.enabled false | ||
| csv.enabled false | ||
| //xml.enabled false | ||
| //csv.enabled false |
There was a problem hiding this comment.
You might need to add a html.required = true in reports part.
common/build.gradle
Outdated
| @@ -45,5 +45,5 @@ jacocoTestCoverageVerification { | |||
| } | |||
| check.dependsOn jacocoTestCoverageVerification | |||
|
|
|||
| lombok.config['lombok.nonNull.exceptionType'] = 'JDK' | |||
| //lombok.config['lombok.nonNull.exceptionType'] = 'JDK' | |||
There was a problem hiding this comment.
You might need to add an additional lombok.config file under the project root, maybe you can follow this - https://github.com/opensearch-project/ml-commons/blob/main/lombok.config
Signed-off-by: Jing Zhang <jngz@amazon.com>
Signed-off-by: Jing Zhang <jngz@amazon.com>
Zhangxunmt
approved these changes
May 23, 2023
ylwu-amzn
approved these changes
May 23, 2023
b4sjoo
pushed a commit
to b4sjoo/ml-commons
that referenced
this pull request
May 30, 2023
* bump 2.8 Signed-off-by: Jing Zhang <jngz@amazon.com> * disable codecov patch Signed-off-by: Jing Zhang <jngz@amazon.com> * address comments Signed-off-by: Jing Zhang <jngz@amazon.com> --------- Signed-off-by: Jing Zhang <jngz@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
b4sjoo
pushed a commit
to b4sjoo/ml-commons
that referenced
this pull request
May 30, 2023
* bump 2.8 Signed-off-by: Jing Zhang <jngz@amazon.com> * disable codecov patch Signed-off-by: Jing Zhang <jngz@amazon.com> * address comments Signed-off-by: Jing Zhang <jngz@amazon.com> --------- Signed-off-by: Jing Zhang <jngz@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
b4sjoo
pushed a commit
to b4sjoo/ml-commons
that referenced
this pull request
May 30, 2023
* bump 2.8 Signed-off-by: Jing Zhang <jngz@amazon.com> * disable codecov patch Signed-off-by: Jing Zhang <jngz@amazon.com> * address comments Signed-off-by: Jing Zhang <jngz@amazon.com> --------- Signed-off-by: Jing Zhang <jngz@amazon.com> Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bump 2.8 to unblock 2.8 release.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.