Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing gradle issue #735

Merged
merged 4 commits into from
Feb 20, 2023
Merged

fixing gradle issue #735

merged 4 commits into from
Feb 20, 2023

Conversation

dhrubo-os
Copy link
Collaborator

Description

[As mac doesn't support GPU building fails in mac. shows error :

Caused by: java.lang.UnsatisfiedLinkError: no onnxruntime in java.library.path: /Users/dhrubo/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:.

]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os requested a review from a team February 18, 2023 02:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #735 (d270683) into 2.x (ffb8a4e) will increase coverage by 0.10%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #735      +/-   ##
============================================
+ Coverage     84.95%   85.05%   +0.10%     
- Complexity     1076     1078       +2     
============================================
  Files           100      100              
  Lines          3922     3922              
  Branches        370      370              
============================================
+ Hits           3332     3336       +4     
+ Misses          433      430       -3     
+ Partials        157      156       -1     
Flag Coverage Δ
ml-commons 85.05% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/opensearch/ml/model/MLModelManager.java 78.60% <0.00%> (ø)
.../cluster/MLCommonsClusterManagerEventListener.java 79.41% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn
Copy link
Collaborator

Mend security check failed,

Dependency Hierarchy:

-> opensearch-2.6.0-SNAPSHOT.jar (Root Library)

   -> opensearch-x-content-2.6.0-SNAPSHOT.jar

     -> ❌ snakeyaml-1.33.jar (Vulnerable Library)

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os
Copy link
Collaborator Author

Mend security check failed,

Dependency Hierarchy:

-> opensearch-2.6.0-SNAPSHOT.jar (Root Library)

   -> opensearch-x-content-2.6.0-SNAPSHOT.jar

     -> ❌ snakeyaml-1.33.jar (Vulnerable Library)

I don't think there's anything we can do about this.

Related issue from opensearch core: opensearch-project/OpenSearch#5576

The original issue is still open: https://bitbucket.org/snakeyaml/snakeyaml/issues/561/cve-2022-1471-vulnerability-in

May be we can ignore this vulnerability as we don't use snakeyml directly.

@dhrubo-os dhrubo-os merged commit 5904a41 into opensearch-project:2.x Feb 20, 2023
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 3, 2023
* fixing gradle issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE-2022-1471

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* avoiding deprecation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 4, 2023
* fixing gradle issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE-2022-1471

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* avoiding deprecation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 4, 2023
* fixing gradle issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE-2022-1471

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* avoiding deprecation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
ylwu-amzn pushed a commit that referenced this pull request Mar 4, 2023
* fixing gradle issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE-2022-1471

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing CVE issue

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* avoiding deprecation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants