Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gpu doc with docker test. #702

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Jan 20, 2023

Signed-off-by: Jing Zhang jngz@amazon.com

Description

Update gpu doc with docker test.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jing Zhang <jngz@amazon.com>
@jngz-es jngz-es requested a review from a team January 20, 2023 02:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #702 (542236c) into 2.x (6ae9257) will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #702      +/-   ##
============================================
+ Coverage     83.97%   84.18%   +0.21%     
- Complexity     1033     1035       +2     
============================================
  Files            99       99              
  Lines          3738     3738              
  Branches        344      344              
============================================
+ Hits           3139     3147       +8     
+ Misses          453      445       -8     
  Partials        146      146              
Flag Coverage Δ
ml-commons 84.18% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ml/task/MLTaskManager.java 65.98% <0.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sudo sysctl -w vm.max_map_count=262144
docker run -it --runtime=nvidia --gpus all -p 9200:9200 nvidia/cuda:11.6.2-cudnn8-devel-ubuntu20.04 /bin/bash
```
Docker:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start OpenSearch in nivida/cuda docker container

- Amazon Linux AMI: `AWS Deep Learning Base AMI GPU CUDA 11 (Ubuntu 20.04) 20221104`
- PyTorch: 1.12.1
- Docker: 20.10.21
- CUDA: 11.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add cuda version after line 13, 62?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Signed-off-by: Jing Zhang <jngz@amazon.com>
@jngz-es jngz-es requested a review from ylwu-amzn January 20, 2023 22:15
@ylwu-amzn ylwu-amzn merged commit a788998 into opensearch-project:2.x Jan 24, 2023
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
* Update gpu doc with docker test.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address comments.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 3, 2023
* Update gpu doc with docker test.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address comments.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 3, 2023
* Update gpu doc with docker test.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address comments.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
ylwu-amzn pushed a commit that referenced this pull request Mar 4, 2023
* Update gpu doc with docker test.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address comments.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
@jngz-es jngz-es deleted the gpu-doc branch May 23, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants